Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](security) All sk in ms log should be encrypted #43544

Merged
merged 4 commits into from
Nov 12, 2024
Merged

[Fix](security) All sk in ms log should be encrypted #43544

merged 4 commits into from
Nov 12, 2024
+127 −1

Conversation

Yukang-Lian
Copy link
Collaborator

@Yukang-Lian Yukang-Lian commented Nov 10, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

github-actions[bot]
github-actions bot reviewed Nov 10, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@Yukang-Lian
Copy link
Collaborator Author

run buildall

github-actions[bot]
github-actions bot reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@Yukang-Lian
Copy link
Collaborator Author

run buildall

github-actions[bot]
github-actions bot reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@Yukang-Lian
Copy link
Collaborator Author

run cloudut

1 similar comment
@Yukang-Lian
Copy link
Collaborator Author

run cloudut

@apache apache deleted a comment from github-actions bot Nov 12, 2024
@apache apache deleted a comment from github-actions bot Nov 12, 2024
@apache apache deleted a comment from github-actions bot Nov 12, 2024
@apache apache deleted a comment from github-actions bot Nov 12, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

liaoxin01
liaoxin01 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou gavinchou merged commit 954661c into apache:master Nov 12, 2024
27 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 12, 2024
@Yukang-Lian
[Fix](sk) All sk in log should be encrypted (#43544)
98a2f93
@github-actions github-actions bot mentioned this pull request Nov 12, 2024
Merged
@gavinchou gavinchou changed the title [Fix](sk) All sk in log should be encrypted [Fix](security) All sk in ms log should be encrypted Nov 12, 2024
py023 pushed a commit to py023/doris that referenced this pull request Nov 13, 2024
@Yukang-Lian @py023
[Fix](sk) All sk in log should be encrypted (apache#43544)
536e2e1
gavinchou pushed a commit that referenced this pull request Nov 13, 2024
@github-actions @Yukang-Lian
branch-3.0: [Fix](sk) All sk in log should be encrypted (#43544) (#43802
85720ac 
)

Cherry-picked from #43544

Co-authored-by: abmdocrt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@liaoxin01 liaoxin01 liaoxin01 approved these changes

@gavinchou gavinchou gavinchou approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. cir dev/3.0.3-merged p0_c reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yukang-Lian @doris-robot @gavinchou @liaoxin01 @dataroaring