Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement](docs) Sql function compress and uncompress #1955

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lzyy2024
Copy link

Versions

  • [x ] dev
  • [x ] 3.0
  • 2.1
  • 2.0

Languages

  • [x ] Chinese
  • [x ] English

Docs Checklist

  • Checked by AI
  • Test Cases Built


## Parameters

| 参数 | 说明 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there shouldn't be Chinese character in English docs

select compress('abc');
```
```text
+----------------------------------+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add case about empty string input

## Syntax

```sql
SELECT(<uncompressed>, <compressed>)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems it's wrong? should be COMPRESS(<uncompressed_str>)?

## Syntax

```sql
UNCOMPRESS(<compressed>, <uncompressed>)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong, uncompress only accept one arg

select uncompress(compress('abc'));
```
```text
+-----------------------------+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add more cases which got NULL, or empty

| 0x03000000789C4B4C4A0600024D0127 |
+----------------------------------+
```
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add sql here, and remove mysql>

```
mysql> select compress('');
```
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add text here

Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants