-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement](docs) Sql function compress and uncompress #1955
base: master
Are you sure you want to change the base?
Conversation
|
||
## Parameters | ||
|
||
| 参数 | 说明 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there shouldn't be Chinese character in English docs
select compress('abc'); | ||
``` | ||
```text | ||
+----------------------------------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add case about empty string input
## Syntax | ||
|
||
```sql | ||
SELECT(<uncompressed>, <compressed>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems it's wrong? should be COMPRESS(<uncompressed_str>)?
## Syntax | ||
|
||
```sql | ||
UNCOMPRESS(<compressed>, <uncompressed>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong, uncompress only accept one arg
select uncompress(compress('abc')); | ||
``` | ||
```text | ||
+-----------------------------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add more cases which got NULL, or empty
cd7da31
to
3fad78c
Compare
| 0x03000000789C4B4C4A0600024D0127 | | ||
+----------------------------------+ | ||
``` | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add sql
here, and remove mysql>
``` | ||
mysql> select compress(''); | ||
``` | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add text
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Versions
Languages
Docs Checklist