Skip to content

Comments

chore: Cleanup "!is_valid(i)" -> "is_null(i)"#20453

Merged
Jefffrey merged 1 commit intoapache:mainfrom
neilconway:neilc/cleanup-is-not-valid-is-null
Feb 21, 2026
Merged

chore: Cleanup "!is_valid(i)" -> "is_null(i)"#20453
Jefffrey merged 1 commit intoapache:mainfrom
neilconway:neilc/cleanup-is-not-valid-is-null

Conversation

@neilconway
Copy link
Contributor

Which issue does this PR close?

N/A

Rationale for this change

This makes the code easier to read; per suggestion from @Jefffrey in code review for a different change.

What changes are included in this PR?

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@neilconway
Copy link
Contributor Author

cc @Jefffrey

@github-actions github-actions bot added physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt) common Related to common crate labels Feb 20, 2026
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neilconway it makes sense

@Jefffrey Jefffrey added this pull request to the merge queue Feb 21, 2026
Merged via the queue into apache:main with commit 7f99947 Feb 21, 2026
32 checks passed
@Jefffrey
Copy link
Contributor

Thanks @neilconway & @comphead, nice cleanup

@neilconway neilconway deleted the neilc/cleanup-is-not-valid-is-null branch February 21, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to common crate physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants