doc-gen: migrate builtin scalar functions documentation to attribute based #13878
+2,662
−3,503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @Chen-Yuan-Lai -- this looks epic! Given the size of this PR I suspect it will be hard to find time to review and also hard to keep up to date (it will likely accumulate conflicts quickly) as it already has a substantial number: Would it be possibel to break it down into a number of smaller PRs (maybe one PR for each |
|
@alamb Sure! I'll break it down into smaller PRs. Thank you for the suggestion. |
|
I can help with reviewing the smaller PR's once they are submitted |
|
Great work 💪 thanks @Chen-Yuan-Lai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13671
Rationale for this change
What changes are included in this PR?
As discussed in #13671 , this PR will migrate the builtin scalar functions documentation that currently support migration.
Are these changes tested?
Are there any user-facing changes?