Restore DocBuilder::new() to avoid breaking API change
#13870
+33
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
DocBuilder::new() to avoid API changeDocBuilder::new() to avoid breaking API change
Omega359
reviewed
Dec 22, 2024
datafusion/sql/src/statement.rs
Outdated
| @@ -62,8 +62,8 @@ use sqlparser::ast::{ | |||
| Assignment, AssignmentTarget, ColumnDef, CreateIndex, CreateTable, | |||
| CreateTableOptions, Delete, DescribeAlias, Expr as SQLExpr, FromTable, Ident, Insert, | |||
| ObjectName, ObjectType, OneOrManyWithParens, Query, SchemaName, SetExpr, | |||
| ShowCreateObject, Statement, TableConstraint, TableFactor, TableWithJoins, | |||
| TransactionMode, UnaryOperator, Value, | |||
| ShowCreateObject, ShowStatementFilter, Statement, TableConstraint, TableFactor, | |||
There was a problem hiding this comment.
cargo fmt drive by change?
There was a problem hiding this comment.
I think it was something I needed to to do iix the build. I'll merge up and it should go away
comphead
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
DocBuildermigration in44.0.0easier #13764Rationale for this change
I would like to help people upgrade DataFusion versions with as much help as possible. This means following the deprecation guidelines
Changes to
DocBuilderintroduced a breaking API change that could be confusing to some during upgraderelated_udf,alternative_syntax#13575What changes are included in this PR?
DocumentationBuilder::new, and mark it `#[deprecated]``, following the deprecation guidelinesDocumentationBuilder::new_with_defaultsnew to help users find the new APIDefaultforDocSectionto make it easier for users to bash out their own docsAre these changes tested?
Are there any user-facing changes?