Feature scalar regexp match benchmark #13789
Open
+135
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#13669) * Minor: Comment temporary function for documentation migration * Minor: Comment temporary function for documentation migration
* Minor: Rephrase MSRV policy to be more explanatory Co-authored-by: Andrew Lamb <[email protected]> * MSRV policy update --------- Co-authored-by: Andrew Lamb <[email protected]>
* Remove unused dependencies from macros crate * rename macro lib to user_doc
* update * update * update * clean up errors * fix flags types * fix failed example
… owned `ColumnReference`) (apache#13637) * Improve documentation * Pass owned args to ScalarFunctionArgs * Update advanced_udf with example of reusing arrays * clarify rationale for cloning * clarify comments * fix expected output
* refactor: use `LazyLock` in the `user_doc` macro * Fix cargo doc * Update datafusion/macros/src/lib.rs * Fix doc comment --------- Co-authored-by: Oleks V <[email protected]>
Issue was patched as of lexical release 1.0.5. Reverts apache#13689 Closes apache#13686
* fix: join with sort push down * chore: insert some value * apply suggestion * recover handle_costom_pushdown change * apply suggestion * add more test * add partition
…3688) Co-authored-by: zhangli20 <[email protected]>
* Optimize performance of function Signed-off-by: Tai Le Manh <[email protected]> * Add pre-check array is null * Fix clippy warnings --------- Signed-off-by: Tai Le Manh <[email protected]>
Updates the requirements on [prost-build](https://github.com/tokio-rs/prost) to permit the latest version. - [Release notes](https://github.com/tokio-rs/prost/releases) - [Changelog](https://github.com/tokio-rs/prost/blob/master/CHANGELOG.md) - [Commits](tokio-rs/prost@v0.13.3...v0.13.4) --- updated-dependencies: - dependency-name: prost-build dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Minor: Output elapsed time for sql logic test
…rojectionMapping` and `EquivalenceGroup` (apache#13675) * refactor: replace Vec with IndexMap for expression mappings in ProjectionMapping and EquivalenceGroup * chore * chore: Fix CI * chore: comment * chore: simplify
* fix: Fix parse_sql_expr not handling alias * cargo fmt * fix parse_sql_expr example(remove alias) * add testing * add SUM udaf to TestContextProvider and modify test_sql_to_expr_with_alias for function * revert change on example `parse_sql_expr`
apache#13730) Debug trait is useful for understanding what something is and how it's configured, especially if the implementation is behind dyn trait.
…13660) * add `unnest_as_table_factor` and `UnnestRelationBuilder` * unparse unnest as table factor * fix typo * add tests for the default configs * add a static const for unnest_placeholder * fix tests * fix tests
|
I ran your benchmark and it looks good. I am unsure though the benefit of this benchmark over the existing 'regx' benchmark which targets the udf versions of the Postgresql symbols - most of the logic is in the regexp::regexp_is_match function for both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Adding benchmark for scalar regex matching, I pick 6 cases for benchmark:
1、email
2、ip
3、phnone number
4、html tag
5、url
6、format date string ('yyyy-MM-dd')
Are these changes tested?
Are there any user-facing changes?