chore: reinstate find_df_window_func #13708
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Dec 9, 2024
| @@ -840,6 +840,12 @@ impl WindowFunction { | |||
| } | |||
| } | |||
|
|
|||
| /// Find DataFusion's built-in window function by name. | |||
| #[deprecated(since = "44.0.0", note = "built-in window functions have been removed")] | |||
There was a problem hiding this comment.
Shall we give a hint about the best replacement API?
There was a problem hiding this comment.
I'll have to research what the replacement API is first, but yes, that would be good. Once I have Comet tests passing, I will come back and improve this.
findepi
reviewed
Dec 10, 2024
Comment on lines
+845
to
+846
| pub fn find_df_window_func(_name: &str) -> Option<WindowFunctionDefinition> { | ||
| None |
There was a problem hiding this comment.
As someone who did upgrades, I'd appreciate a compiler error more than a dummy implementation.
But we can do good here. We can see what's the name being looked up and return non-built-in implementation based on that. The return type allows to do this, fortunately.
There was a problem hiding this comment.
That makes sense. I am moving this to draft until I can implement the feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #13702
Rationale for this change
Public API function
find_df_window_funcwas removed in #13201. It would be better to deprecate it and remove it in a future release.What changes are included in this PR?
Add deprecated method.
Are these changes tested?
Are there any user-facing changes?