-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add invoke fix tests #13491
Draft
joseph-isaacs
wants to merge
15
commits into
apache:main
Choose a base branch
from
spiraldb:ji/add-invoke-fix-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add invoke fix tests #13491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
sql
SQL Planner
logical-expr
Logical plan and expressions
physical-expr
Physical Expressions
optimizer
Optimizer rules
core
Core DataFusion crate
functions
labels
Nov 19, 2024
…invoke is passed the return type created for the udf instance
joseph-isaacs
force-pushed
the
ji/add-invoke-fix-tests
branch
from
November 19, 2024 15:56
19632b5
to
6b3db8c
Compare
Do not yet deprecate `invoke_batch`, add docs to invoke_with_args
# Conflicts: # datafusion/expr/src/udf.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
core
Core DataFusion crate
documentation
Improvements or additions to documentation
functions
logical-expr
Logical plan and expressions
optimizer
Optimizer rules
physical-expr
Physical Expressions
proto
Related to proto crate
sql
SQL Planner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?