Support custom field metadata in UDF #13458
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Nov 18, 2024
| @@ -216,6 +217,15 @@ impl ScalarUDF { | |||
| self.inner.is_nullable(args, schema) | |||
| } | |||
|
|
|||
| /// Returns the field metadata for this function. | |||
| pub fn metadata( | |||
There was a problem hiding this comment.
Looks like not. This pr is for supporting custom metadata when converting scalar function expr to schema field during planing.
findepi
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
In our case, we need put type data in schema metadata for supporting logical type. But there is no good way for the column generated by UDF.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?