feat: Run (logical) optimizers on subqueries #13066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
This patch makes it so that rules the configure an `apply_order` will also include subqueries in their traversel. This is a step twoards being able to run TPC-DS q41 (apache#4763) which has an expressions that needs simplification before we can decorrelate the subquery. This closes apache#3770 and maybe apache#2480
eejbyfeldt
force-pushed
the
i-3770-also-optimize-subqueries
branch
from
bf8b752 to
df84a84
Compare
alamb
reviewed
Oct 22, 2024
| @@ -250,10 +250,6 @@ impl Optimizer { | |||
| Arc::new(DecorrelatePredicateSubquery::new()), | |||
| Arc::new(ScalarSubqueryToJoin::new()), | |||
| Arc::new(ExtractEquijoinPredicate::new()), | |||
| // simplify expressions does not simplify expressions in subqueries, so we | |||
There was a problem hiding this comment.
❤️
This may also make planning non trivially faster as SimplifyExpressions is quite expensive
Dandandan
reviewed
Oct 23, 2024
| @@ -384,11 +380,9 @@ impl Optimizer { | |||
|
|
|||
| let result = match rule.apply_order() { | |||
| // optimizer handles recursion | |||
| Some(apply_order) => new_plan.rewrite(&mut Rewriter::new( | |||
There was a problem hiding this comment.
I think we owe a significant debt to @peter-toth for his work on the tree node API to sort out how to handle subqueries
|
Thanks @eejbyfeldt. |
alamb
reviewed
Oct 23, 2024
| 05)--------TableScan: t1 | ||
| 06)--------TableScan: t2 | ||
| 07)--TableScan: t0 projection=[t0_id, t0_name] | ||
| 01)LeftSemi Join: t0.t0_name = __correlated_sq_2.t1_name |
| @@ -384,11 +380,9 @@ impl Optimizer { | |||
|
|
|||
| let result = match rule.apply_order() { | |||
| // optimizer handles recursion | |||
| Some(apply_order) => new_plan.rewrite(&mut Rewriter::new( | |||
There was a problem hiding this comment.
I think we owe a significant debt to @peter-toth for his work on the tree node API to sort out how to handle subqueries
eejbyfeldt
added a commit
to eejbyfeldt/datafusion
that referenced
this pull request
Oct 30, 2024
With apache#13066 we run optimizer rules on subquries by default which resolved issue apache#5771
eejbyfeldt
added a commit
to eejbyfeldt/datafusion
that referenced
this pull request
Oct 30, 2024
With apache#13066 we run optimizer rules on subquries by default which resolved issue apache#5771
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3770 and maybe #2480
Rationale for this change
This is a step towards being able to run TPC-DS q41 (#4763) which has an
expressions that needs simplification before our rules can decorrelate the
subquery.
What changes are included in this PR?
This patch makes it so that rules the configure an
apply_orderwillalso include subqueries in their traversel.
Are these changes tested?
Existing tests.
Are there any user-facing changes?
Yes, subqueries will now also be optimized.