address feedback

apache · Dec 11, 2024 · 4e08770 · 4e08770
1 parent 97b037b
commit 4e08770
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/datafusion/core/src/catalog_common/information_schema.rs b/datafusion/core/src/catalog_common/information_schema.rs
@@ -406,6 +406,7 @@ fn get_udf_args_and_return_types(
             .into_iter()
             .map(|arg_types| {
                 // only handle the function which implemented [`ScalarUDFImpl::return_type`] method
+                #[allow(deprecated)]
                 let return_type = udf.return_type(&arg_types).ok().map(|t| t.to_string());
                 let arg_types = arg_types
                     .into_iter()

diff --git a/datafusion/expr/src/udf.rs b/datafusion/expr/src/udf.rs
@@ -173,6 +173,7 @@ impl ScalarUDF {
     /// its [`ScalarUDFImpl::return_type`] should raise an error.
     ///
     /// See [`ScalarUDFImpl::return_type`] for more details.
+    #[deprecated(since = "44.0.0", note = "Use return_type_from_exprs() instead")]
     pub fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
         #[allow(deprecated)]
         self.inner.return_type(arg_types)