refactor(11770): provide deprecation warning for TryFrom

apache · Dec 21, 2024 · 1a9da6f · 1a9da6f
1 parent 7a6a276
commit 1a9da6f
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/datafusion/common/src/file_options/parquet_writer.rs b/datafusion/common/src/file_options/parquet_writer.rs
@@ -59,6 +59,17 @@ impl ParquetWriterOptions {
 }
 
 impl TableParquetOptions {
+    #[deprecated(
+        since = "44.0.0",
+        note = "Please use `TableParquetOptions::into_writer_properties_builder` and `TableParquetOptions::into_writer_properties_builder_with_arrow_schema`"
+    )]
+    pub fn try_from(table_opts: &TableParquetOptions) -> Result<ParquetWriterOptions> {
+        // ParquetWriterOptions will have defaults for the remaining fields (e.g. sorting_columns)
+        Ok(ParquetWriterOptions {
+            writer_options: table_opts.into_writer_properties_builder()?.build(),
+        })
+    }
+
     /// Convert the session's [`TableParquetOptions`] into a single write action's [`WriterPropertiesBuilder`].
     ///
     /// The returned [`WriterPropertiesBuilder`] includes customizations applicable per column.