fix q35 #17
fix q35 #17
Conversation
| min(cd_dep_count), | ||
| max(cd_dep_count), | ||
| stddev_samp(cd_dep_count), | ||
| stddev_samp(cd_dep_count), | ||
| avg(cd_dep_count), |
There was a problem hiding this comment.
The queries in this repo are the official queries as generated by the TPC-DS query generator provided by the TPC. I don't think that we should be changing them?
There was a problem hiding this comment.
I think the query generator has a bug in this case, see https://github.com/apache/datafusion/blob/main/datafusion/core/tests/tpc-ds/35.sql as another generated version that correctly substituted the aggregations
There was a problem hiding this comment.
You are correct. I just checked the query description in the TPC-DS specification, and it does not use stdev_sample. I wonder if this was inadvertently checked in after some manual experimentation. Thanks for catching this!
There was a problem hiding this comment.
No worries, latest version of the tpc-ds generator also generated this query wrong for me, so I think it is some bug in the param substitution in the dsqgen executable
per apache/datafusion#4763 (comment) , q35 should be able to be executed now without column name collusions