Update scala-library, scala-reflect to 2.12.17

[scala-steward]

Updates

• org.scala-lang:scala-library
• org.scala-lang:scala-reflect

from 2.12.15 to 2.12.17.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (2.12.15).
You might want to review and update them manually.

daffodil-japi/build.sbt

Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scala-lang" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

[tuxji]

Does not build. The failure to find a scoverage dependency may mean that we just need to wait for the ecosystem to catch up and build new versions. Let's wait to see if this PR becomes buildable after 1-2 weeks.

[stevedlawrence]

It looks like scoverage has only created 2.12.17 builds for versions 2.0.5 and 2.0.3 of the scalac plugin:

https://search.maven.org/artifact/org.scoverage/scalac-scoverage-plugin_2.12.17

To get either of those versions of the scalac plugin we need to bump the sbt-scoverage plugin to 2.0.x, but those versions have known issues with windows. So because we can't bump sbt-scoverage, we can't bump the scala version. And we also can't bump sbt-native-packager (PR #826).

So we're now running into issues because of this windows problem in sbt-scoverage.

We could maybe try to disable coverage on windows until this is fixed. The GitHub actions files might get a bit ugly.

Alternatively, we could try to put some effort into fixing the sbt-scoverage issue and submitting a PR. It doesn't seem like it's high priority for the devs, so it may not get fixed without outside input.

[stevedlawrence]

+1

sbt-scoverage has created a new release that fixes the problems with windows. Due to dependencies, I've updated this PR to update scala, sbt-scoverage, and sbt-native-packager.

We do not distribute the two sbt plugins so there are no licensing concerns There are no new features we really need compared to the old versions, but they do update dependencies, e.g. scala-xml

The scala update is ALv2 and so is compatible with Apache licenses, and our NOTICE/LICENSE files are already accurate. This also includes some important changes, such as always generating Java 8 bytecode for compatibility.

[stevedlawrence]

+1

[tuxji]

+1

Great to see this resolved (we just had to wait a long time for newer versions to fix the issues :).