Daf 2959 cleanup #1381
Open
Daf 2959 cleanup #1381
+197
−265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved TestUtils and FuzzData in core to src/main so FuzzData can be used outside of daffodil proper. Removed unused and trivial methods from TestUtils. Made private all methods possible. We're left with minimum footprint of public methods. Removed dependency on JUnit from TestUtils and FuzzData so they don't have to be in src/test. Tested for and removed a couple of TODOs that are no longer needed. Reducing the number of TODOs and FIXMEs is DAFFODIL-1569. DAFFODIL-2959, DAFFODIL-1569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved TestUtils and FuzzData in core to src/main
so FuzzData can be used outside of daffodil proper.
Removed unused and trivial methods from TestUtils.
Made private all methods possible.
We're left with minimum footprint of public methods.
Removed dependency on JUnit from TestUtils and FuzzData so they don't have to be in src/test.
Tested for and removed a couple of TODOs that are no longer needed.
Reducing the number of TODOs and FIXMEs is DAFFODIL-1569.
DAFFODIL-2959, DAFFODIL-1569
Add final
DAFFODIL-2797