Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce HiddenGroupRef not being model group of Complex Type #1380

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enforce HiddenGroupRef not being model group of Complex Type #1380

wants to merge 1 commit into from
+68 −10

Conversation

olabusayoT
Copy link
Contributor

@olabusayoT olabusayoT commented Nov 21, 2024 •
edited
Loading

  • currently we don't check if a hiddenGroupRef is the model group of a complexType, which allows schemas to have them. This check will ensure schemas can't have hiddenGroupRefs as their model group, and instead suggest wrapping the HGR in an empty sequence
  • add test to show SDE
  • update tests with HiddenGroupRef as model group of ComplexType

DAFFODIL-2419

@olabusayoT
Enforce HiddenGroupRef not being model group of Complex Type
3cacffb 
- currently we don't check if a hiddenGroupRef is the model group of a complexType, which allows schemas to have them. This check will ensure schemas can't have hiddenGroupRefs as their model group, and instead recommends wrapping the HGR in an empty sequence
- add test to show SDE
- update tests with HiddenGroupRef as model group of ComplexType

DAFFODIL-2419
mbeckerle
mbeckerle approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@mbeckerle mbeckerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbeckerle mbeckerle mbeckerle approved these changes

@stevedlawrence stevedlawrence Awaiting requested review from stevedlawrence

@jadams-tresys jadams-tresys Awaiting requested review from jadams-tresys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olabusayoT @mbeckerle