Added tests of decimalSigned to show that it fails in a few cases. #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olabusayoT
reviewed
Nov 18, 2024
daffodil-test/src/test/resources/org/apache/daffodil/section13/decimal/TestDecimalSigned.tdml
Show resolved
Hide resolved
daffodil-test/src/test/resources/org/apache/daffodil/section13/decimal/TestDecimalSigned.tdml
Show resolved
Hide resolved
Tests show that parse of negative representations (from packed decimal reps) does not detect the error when decimalSigned="no". Test aalso show that unparse of negative values into binary, packed, and bcd all are broken. This doesn't fix the issue. Just adds tests to illustrate the failing cases. DAFFODIL-2957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR has 2 commits. The first one is for a separate feature (with separate PR) that I'm depending on in this PR. Please ignore that first commit and review the 2 files of changes in the 2nd commit.
Tests show that parse of negative representations (from packed decimal reps) does not detect the error when decimalSigned="no".
Test also show that unparse of negative values into binary, packed, and bcd all are broken.
This doesn't fix the issue. Just adds tests to illustrate the failing cases.
DAFFODIL-2957