Skip to content

Conversation

@kumo01GitHub
Copy link
Contributor

@kumo01GitHub kumo01GitHub commented Apr 24, 2025

Platforms affected

Android

Motivation and Context

Following below comment:
apache/cordova-plugin-geolocation#291 (comment)

The Apache Software Foundation is moving toward blocking tags like v1 and prefers commit hash IDs instead.

I agree because we can avoid unexpected change such as caused by third-party tool makes breaking-change without update major version or remakes tags.

Description

  • Change ReactiveCircus/android-emulator-runner@v2 to v2.34.0's commit id
  • The other tools are GitHub’s core actions or already using commit id

Testing

Android Testsuite successed.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@kumo01GitHub kumo01GitHub marked this pull request as ready for review April 27, 2025 08:08
@kumo01GitHub kumo01GitHub marked this pull request as draft April 27, 2025 08:12
@kumo01GitHub kumo01GitHub reopened this Apr 27, 2025
@kumo01GitHub kumo01GitHub marked this pull request as ready for review April 27, 2025 08:26
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Confirmed the commit id by comparing the hash on their tag:

https://github.com/reactivecircus/android-emulator-runner/commits/v2.34.0/

@erisu erisu merged commit d676b31 into apache:master Jul 15, 2025
11 of 15 checks passed
@kumo01GitHub kumo01GitHub deleted the ci/use-commitid branch July 15, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants