Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response object required by go SDK for parsing response #10152

Open
wants to merge 2 commits into
base: 4.19
Choose a base branch
from

Conversation

Pearl1594
Copy link
Contributor

Description

This PR adds the StatsResponse object which is required by the go SDK - to resolve the following issue: apache/cloudstack-go#97

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.13%. Comparing base (5c01cff) to head (6931d1b).

Additional details and impacted files
@@            Coverage Diff            @@
##               4.19   #10152   +/-   ##
=========================================
  Coverage     15.12%   15.13%           
- Complexity    11264    11266    +2     
=========================================
  Files          5408     5408           
  Lines        473899   473899           
  Branches      57791    57791           
=========================================
+ Hits          71691    71713   +22     
+ Misses       394208   394181   -27     
- Partials       8000     8005    +5     
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.85% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, but a lot of new failures. Any idea @Pearl1594 ?

@Pearl1594
Copy link
Contributor Author

I may have not pulled the latest 4.19 branch - let's see if this helps

@Pearl1594
Copy link
Contributor Author

Actually, seems like this is the issue:

 /home/runner/.local/lib/python3.10/site-packages/nose/plugins/manager.py:394: RuntimeWarning: Unable to load plugin marvinPlugin = marvin.marvinPlugin:MarvinPlugin: unterminated string literal (detected at line 95) (listVirtualMachinesUsageHistory.py, line 95)
  warn("Unable to load plugin %s: %s" % (ep, e),

Not sure why is this being caused - needs investigation

Copy link

sonarqubecloud bot commented Jan 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants