-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add response object required by go SDK for parsing response #10152
base: 4.19
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10152 +/- ##
=========================================
Coverage 15.12% 15.13%
- Complexity 11264 11266 +2
=========================================
Files 5408 5408
Lines 473899 473899
Branches 57791 57791
=========================================
+ Hits 71691 71713 +22
+ Misses 394208 394181 -27
- Partials 8000 8005 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, but a lot of new failures. Any idea @Pearl1594 ?
…dk-response-obj
I may have not pulled the latest 4.19 branch - let's see if this helps |
Actually, seems like this is the issue:
Not sure why is this being caused - needs investigation |
Quality Gate passedIssues Measures |
Description
This PR adds the StatsResponse object which is required by the go SDK - to resolve the following issue: apache/cloudstack-go#97
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?