Linstor: encryption support

[rp-]

Description

This PR main purpose is adding encryption support for Linstor, as Linstor handles the encryption layer (LUKS)
to allow DRBD running on top of it, we needed a new mode for encryption in CloudStack.
So that CloudStack knows the volume is encrypted, but the encryption/deencryption is handled by the primary storage.
So qemu only gets the final block device path and opening/closing is handled by Linstor.

Additionally there are a few commits for cleanups and a few unittests for Linstor code.
For this to work at least Linstor 1.30.x is needed, as the new cloning code is needed.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Linstor cluster with encrypted disk offering.

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 48.75000% with 41 lines in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (a9587bf) to head (f6bdea0).
Report is 1 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...tore/driver/LinstorPrimaryDataStoreDriverImpl.java	36.11%	21 Missing and 2 partials ⚠️
...e/wrapper/LinstorBackupSnapshotCommandWrapper.java	0.00%	10 Missing ⚠️
api/src/main/java/com/cloud/storage/Storage.java	89.65%	3 Missing ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java	0.00%	0 Missing and 2 partials ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	0.00%	2 Missing ⚠️
.../hypervisor/kvm/storage/LinstorStorageAdaptor.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10126      +/-   ##
============================================
- Coverage     15.13%   15.12%   -0.01%     
- Complexity    11266    11273       +7     
============================================
  Files          5408     5408              
  Lines        473890   474386     +496     
  Branches      57787    57809      +22     
============================================
+ Hits          71704    71734      +30     
- Misses       394183   394641     +458     
- Partials       8003     8011       +8     

Flag	Coverage Δ
uitests	4.30% <ø> (ø)
unittests	15.84% <48.75%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rp-]

@blueorangutan package

[blueorangutan]

@rp- a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11857

[blueorangutan]

[SF] Trillian test result (tid-11960)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 45339 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10126-t11960-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	Error	266.89	test_vm_life_cycle.py