-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Build Pipeline with Debug and Core Analysis Support #784
Conversation
If we do this with a skip CI tag, any later pull requests will fail and cannot be merged. I’m not optimistic that we can fix the core dump issue #782 in a short time. How about we configure the system to allow the mirror_replay case for now? This way, we can separate the core dumps and report them independently. When someone eventually fixes the mirror_replay issue, we can update the configuration to set the expected core dump case to NULL, ensuring that nothing is blocked. |
The best I can do is to disable (ignore) the |
This is indeed a way to address the issue at the moment. However, it means we will miss out on a test case. cc: @my-ship-it |
There are a couple of options:
Personally, I prefer option 1 over 2. I do not know if developers tend to review the details of the workflow action only when there are CI check status failures. A core file warning condition could go unnoticed if the test case passes as is the case with |
@avamingli & @my-ship-it Any thoughts on which approach to take? I have other test suites I would like to enable that is blocked on getting this work completed. |
Hey Ed, thanks for making the enhancement. |
Adds comprehensive debug build support and automated core dump analysis to the Cloudberry build pipeline. Key features: - Debug build capability with preserved symbols and debug-specific RPMs - Automated core dump detection and analysis during test execution - Core file correlation with test failures - Enhanced test result reporting with core dump status - Improved artifact management for debug builds The changes enable better debugging of test failures and provide more detailed information about process crashes during testing.
This test is currently causing core dumps when run as part of the greenplum_schedule. To prevent this from blocking other testing while we investigate the root cause: - Created new fixme_schedule containing only mirror_replay - Removed mirror_replay from greenplum_schedule - Added installcheck-fixme make target to run problematic tests in isolation Issue: apache#782
When enable_check_core is disabled, the test should proceed with a warning rather than failing. Modified the core file check and summary to mark mirror_replay with a warning status in these cases. This complements the previous isolation of this test into fixme_schedule, allowing testing to proceed while we investigate the underlying core dump issue.
22dce70
to
ace1765
Compare
@avamingli & @my-ship-it Please check out the workflow. You will see a new test group |
Fixes: #765
Adds comprehensive debug build support and automated core dump analysis to the Cloudberry build pipeline. Key features:
The changes enable better debugging of test failures and provide more detailed information about process crashes during testing.
I expect the
ic-good-opt-off
group to fail as themirror_replay
test suite is dumping a core. I have filed the following for that issue: Core Dump in mirror_replay Test Suite During Execution #782After the checks have run and
ic-good-opt-off
has failed as expected with core dump, I plan to enable the skip ci optionis PR to allow it to be committed after receiving approval.Benign edit to re-trigger the workflow.