-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAMEL-17881 TLS for MLLP Component #16662
Conversation
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
Thanks, the other components that has SSL also have an option named |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one line not clear
I will look in to it |
12812a5
to
4b7d341
Compare
I added option useGlobalSslContextParameters, added a test for it and removed the old outcommented version in pom |
…ndthread and mllpconfiguration
4b7d341
to
d463dae
Compare
Thanks! I tried rebasing and rebuilding again with mvn clean install. Let's see if that works. |
|
Hmm I cant figure out where they are comming from. I have no uncommitted files after I run build. You can try your PR if you want. |
I will rebuild after this PR |
Thanks! |
Description
This commit makes the mllp component able to specify sslcontextperameters to use tls. This works both when using the mllp component to receive and to send messages. I have had to make some changes in some allready existing classes to make them use SSLServerSocketFactory in case of sslcontextparemeters being present. If sslcontextparemeters are not present it works as before. I had to add changes to the mllptcpserverconsumer and tcpserverbindthread on the server side and mllptcpclientproducer on the client side. I also had to add to the mllpconfiguration class and the mllpendpoint class so the endpoint can be created with sslcontextparameters in the uri. For testing I added an endpoint test to the mllpenpointtest class and I created a new class mllpsslcontextparameterstest for the connection test.
It's my first contribution so feel free to tell me if I should change something or if there are things I have missed completely.
Target
camel-3.x
, whereas Camel 4 uses themain
branch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTests
locally from root folder and I have committed all auto-generated changes.