Micrometer: Router policy should be disabled by default #5028

[JiriOndrusek]

fixes #5028

[jamesnetherton]

We need to document this change of behavior in the migration guide.

FWIW I'm not convinced this is a good from the perspective of UX or migration from the old MicroProfile Metrics extension where the same config property defaults to true.

[JiriOndrusek]

Change in migration doc is part of the PR.
I proposed the PR mainly to see reaction, whether we want this change.
If the change is approved, the same behavior should be proposed to CSB.

[JiriOndrusek]

FWIW I'm not convinced this is a good from the perspective of UX or migration from the old MicroProfile Metrics extension where the same config property defaults to true.

default true is only in CSB. See https://camel.apache.org/components/3.20.x/micrometer-component.html#_sb_option_camel_metrics_enable-route-policy
plain Camel default value is false (context.addRoutePolicyFactory has to be called). See https://camel.apache.org/components/3.20.x/micrometer-component.html#_using_micrometer_route_policy_factory

[jamesnetherton]

@JiriOndrusek sorry, I introduced some conflicts because I had to rename the migration guide.

[zbendhiba]

Thanks @JiriOndrusek
I'm curious why this should be enabled or disabled by default for Camel-Quarkus ?

[JiriOndrusek]

default true is only in CSB. See https://camel.apache.org/components/3.20.x/micrometer-component.html#_sb_option_camel_metrics_enable-route-policy
plain Camel default value is false (context.addRoutePolicyFactory has to be called). See https://camel.apache.org/components/3.20.x/micrometer-component.html#_using_micrometer_route_policy_factory

Just to be consistent with plain camel (where user has to set policy in the code to enable it) -> See https://camel.apache.org/components/3.20.x/micrometer-component.html#_using_micrometer_route_policy_factory

[aldettinger]

No strong opinion. Not sure we need to align with Camel. Aligning Camel Quarkus and Camel Spring Boot looks good.