Skip to content

Conversation

@nikitagrover19
Copy link

Move Row to typehints/row.py, add compatibility alias in pvalue.py, update imports, and update CHANGES.md

This change reorganizes the Python SDK by moving the Row class into a dedicated module under apache_beam.typehints.
The goal is to improve module structure, reduce coupling, and better align Beam’s schema utilities with the type-hinting subsystem.

Description

This PR moves the Row implementation from apache_beam.pvalue into a new file, apache_beam.typehints.row.
This is a more appropriate location for a schema-aware, type-hinted data container and helps simplify the structure of pvalue.py.

To maintain full backward compatibility, pvalue.py now exposes a compatibility alias so that existing user code importing apache_beam.Row continues to work without modification.

Additional Updates

  • Updated apache_beam/init.py to re-export Row.
  • Updated imports wherever the previous module path was used.
  • Added an entry to CHANGES.md documenting the relocation.

This improves code organization and moves schema utilities closer to the rest of Beam’s type-hinting system, without breaking any public APIs.

Fixes #35095


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @nikitagrover19, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Python SDK by relocating the Row class to a more semantically appropriate module within the type-hinting subsystem. This change enhances code organization and reduces coupling, while meticulously preserving backward compatibility for users. The move integrates schema-aware data containers more closely with Beam's type-hinting capabilities, ensuring a cleaner and more logical structure without impacting existing public APIs.

Highlights

  • Module Reorganization: The Row class has been moved from apache_beam.pvalue to a new, dedicated module: apache_beam.typehints.row. This aims to improve the module structure and better align schema utilities with the type-hinting subsystem.
  • Backward Compatibility: A compatibility alias for Row has been added to pvalue.py to ensure that existing user code importing apache_beam.Row continues to function without modification.
  • Import Updates: All necessary import statements across the codebase, including in apache_beam/__init__.py, have been updated to reflect the new location of the Row class.
  • Changelog Documentation: The CHANGES.md file has been updated to document the relocation of the Row class and the introduction of the compatibility alias.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @claudevdm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Expose pvalue.Row in core.py rather than pvalue.py

1 participant