Skip to content

Use internal DEFAULT_PICKLE_LIB #37052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claudevdm merged 2 commits into from
Dec 9, 2025
Merged

Use internal DEFAULT_PICKLE_LIB #37052

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48e432a
Use internal DEFAULT_PICKLE_LIB
Abacn Dec 8, 2025
f2ae7d3
Enable only on Dataflow
Abacn Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions sdks/python/apache_beam/options/pipeline_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1682,15 +1682,16 @@ def _add_argparse_args(cls, parser):
'defined in __main__ (e.g. interactive session) can be unpickled. '
'Some workflows do not need the session state if for instance all '
'their functions/classes are defined in proper modules '
'(not __main__) and the modules are importable in the worker. '))
'(not __main__) and the modules are importable in the worker. '
'It is disabled by default except for cloudpickle as pickle '
'library on Dataflow runner.'))
parser.add_argument(
'--no_save_main_session',
default=None,
action='store_false',
dest='save_main_session',
help=(
'Disable saving the main session state. It is enabled/disabled by'
'default for cloudpickle/dill pickler. See "save_main_session".'))
'Disable saving the main session state. See "save_main_session".'))

parser.add_argument(
'--sdk_location',
Expand Down Expand Up @@ -1795,13 +1796,19 @@ def _add_argparse_args(cls, parser):
def _handle_load_main_session(self, validator):
save_main_session = getattr(self, 'save_main_session')
if save_main_session is None:
# save_main_session default to False for dill, while default to true
# for cloudpickle
pickle_library = getattr(self, 'pickle_library')
if pickle_library in ['default', 'cloudpickle']:
setattr(self, 'save_main_session', True)
else:
if not validator.is_service_runner():
setattr(self, 'save_main_session', False)
else:
# save_main_session default to False for dill, while default to true
# for cloudpickle on service runner
pickle_library = getattr(self, 'pickle_library')
if pickle_library == 'default':
from apache_beam.internal.pickler import DEFAULT_PICKLE_LIB
pickle_library = DEFAULT_PICKLE_LIB
if pickle_library == 'cloudpickle':
setattr(self, 'save_main_session', True)
else:
setattr(self, 'save_main_session', False)
return []

def validate(self, validator):
Expand Down
Loading