Skip to content

Conversation

DKER2
Copy link
Contributor

@DKER2 DKER2 commented Aug 17, 2025

addresses #30445

Fix duplicate transform function name by giving custom label (key in dicts of dataframes) instead of using default label as in this line it will take the first two characters of the variable name to construct the label, so if two variables start with the same two characters(e.g pcol1, pcol2), there will a conflict


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @DKER2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in DataframeTransform within Apache Beam's Python SDK, specifically when it processes a dictionary of PCollections. The fix involves correctly passing an additional argument during the conversion of PCollections to DataFrames, ensuring proper handling of multiple inputs. A new test case has been added to validate this functionality. Additionally, a minor update to a warning message format in core.py is included.

Highlights

  • DataframeTransform Bug Fix: Corrected an issue in sdks/python/apache_beam/dataframe/transforms.py where DataframeTransform failed to properly process a dictionary of PCollections. The fix involves passing str(k) as a third argument to convert.to_dataframe when iterating through dictionary items.
  • New Test Case for Multiple DataFrames: Added test_multiple_dataframe_transforms in sdks/python/apache_beam/dataframe/transforms_test.py to ensure DataframeTransform correctly handles scenarios with multiple input PCollections provided as a dictionary.
  • Warning Message Formatting Update: Updated a warning message in sdks/python/apache_beam/transforms/core.py to use an f-string for improved readability and modern Python syntax.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@DKER2 DKER2 marked this pull request as draft August 17, 2025 14:23
@DKER2 DKER2 marked this pull request as ready for review August 20, 2025 13:58
@DKER2 DKER2 changed the title [DRAFT] Fix bug when DataframeTransform a dictionary of Pcoll Fix bug when execute DataframeTransform a dictionary of Pcoll Aug 20, 2025
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link

codecov bot commented Aug 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.72%. Comparing base (b60ce5b) to head (f1e5fd7).
⚠️ Report is 92 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #35893      +/-   ##
============================================
+ Coverage     56.68%   56.72%   +0.03%     
  Complexity     3380     3380              
============================================
  Files          1219     1220       +1     
  Lines        184480   184844     +364     
  Branches       3507     3507              
============================================
+ Hits         104570   104849     +279     
- Misses        76581    76666      +85     
  Partials       3329     3329              
Flag Coverage Δ
python 80.81% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Assigning reviewers:

R: @damccorm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm
Copy link
Contributor

Thanks. This will potentially break update compatibility for streaming jobs (which rely on step name to map new transforms to old), but I think that it is worth it to allow this kind of usage.

Could you please add a note to CHANGES.md calling out this bug fix?

Copy link
Contributor

github-actions bot commented Sep 2, 2025

Reminder, please take a look at this pr: @damccorm

@ahmedabu98
Copy link
Contributor

waiting on author

@DKER2 DKER2 closed this Sep 4, 2025
@DKER2 DKER2 reopened this Sep 4, 2025
@DKER2
Copy link
Contributor Author

DKER2 commented Sep 4, 2025

Thanks. This will potentially break update compatibility for streaming jobs (which rely on step name to map new transforms to old), but I think that it is worth it to allow this kind of usage.

Could you please add a note to CHANGES.md calling out this bug fix?

Updated CHANGES.md @damccorm. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants