-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distroless python sdk #32960
Merged
damondouglas
merged 12 commits into
apache:master
from
damondouglas:distroless-python-sdk
Nov 6, 2024
Merged
Distroless python sdk #32960
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5c95b28
Enable Python distroless container image variants
damondouglas 060f3b6
Fix missing entrypoint
damondouglas 4167525
Revert testing using validatescontainer.sh
damondouglas de91c8e
Create validateDistrolessContainerTests
damondouglas c244b1b
Refactor for reusable gradle methods
damondouglas d9b955e
Revert back
damondouglas 2ebb919
Finalize gradle
damondouglas 41b4a40
Migrate distroless build to its own gradle task
damondouglas 658d9b3
Remove gradle distroless build task
damondouglas a3c1d4c
Add base target
damondouglas 96d64de
Build docker image directly in test
damondouglas 5c6720c
Revert back to using plugin
damondouglas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overwriting root properties may have surprising effect, saying if one creates another task that produces container sequentially,
Could it happen that py39-distroless invocation affects the configurations for the py310 target? If so is there a way to avoid it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abacn , thank you for meeting with me a couple days back. I realized that having separate
py<version>-distroless
gradle projects could be avoided with the logic introduced in container/common.gradle by querying thecontainer-build-target
property. Thus, there is nopy<version>-distroless
. The description has a screenshot in the collapsed markdown of the Dataflow Job that succeeded with thevalidatesDistrolessContainer
task. I don't have the means while currently on vacation to test again but I (mostly) remember that the tag is needed to be set on the rootProject level to work.validatesDistrolessContainer
should not interfere with other tasks and these properties should only be set when the task executes, not when it is configured.