-
Notifications
You must be signed in to change notification settings - Fork 44
feat: Support fixed as type for uuid
#339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kriskras99
wants to merge
3
commits into
main
Choose a base branch
from
uuid
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
reviewed
Nov 23, 2025
martin-g
reviewed
Nov 23, 2025
martin-g
reviewed
Dec 8, 2025
Contributor
Author
|
I think this is ready to merge now |
fixed as type for uuidfixed as type for uuid
Contributor
Author
|
I've rebased this PR on main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Avro 1.12 official support for the
fixedtype was added for the logical typeuuid. avro-rs had a different interpretation of that and would rewrite it to abytestype.To remain compatible with the legacy implementation, avro-rs now supports
string,fixed, andbytes.bytesdoes not match spec, but does allow users to read already encoded data.This is a severe breaking change, although only for people who only use avro-rs (the legacy encoding did not, and still does not work with other languages).
I've also reworked
Schema::Decimalto use a similar setup asSchema::Uuidwhich saves aBoxand does not make the type bigger.