ARROW-11194: [Rust] Enable packed_simd for aarch64#9148
ARROW-11194: [Rust] Enable packed_simd for aarch64#9148nevi-me wants to merge 2 commits intoapache:masterfrom
Conversation
packed_simd has support for aarch64 for the functions that we are using.
|
@alamb @jorgecarleitao I see decent performance increases in benchmarks, but because my device gets hot running the benchmarks, I'm opting to view them as not too reliable. |
Codecov Report
@@ Coverage Diff @@
## master #9148 +/- ##
==========================================
- Coverage 81.81% 81.80% -0.02%
==========================================
Files 214 214
Lines 51373 51383 +10
==========================================
+ Hits 42033 42034 +1
- Misses 9340 9349 +9
Continue to review full report at Codecov.
|
|
#8891 added |
|
How about merging cfg_aliases! {
simd: { all(any(target_arch = "x86", target_arch = "x86_64", target_arch = "aarch64"), feature = "simd") },
} |
+1 because the codes make no difference for all targets |
|
List some possible TODO/discussion about the SIMD feature:
[1] Quote from https://en.wikipedia.org/wiki/SIMD: |
No, because we want
ARROW-6410 mainly deals with this. I'd opt not to document anything on this PR, as we have activity on JIRA documenting our use of SIMD. |
|
@nevi-me got it, thanks! |
alamb
left a comment
There was a problem hiding this comment.
Seems like a good change to me
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9148 +/- ##
==========================================
- Coverage 81.81% 81.80% -0.02%
==========================================
Files 214 214
Lines 51373 51383 +10
==========================================
+ Hits 42033 42034 +1
- Misses 9340 9349 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
packed_simd has support for aarch64 for the functions that we are using.
We can't test this feature yet, as we don't have aarch64 targets on our Rust CI yet. I however tested this on an ARM Mac device.
I perceive the build risk to be low, as I'm only enabling
aarch64in addition to the already usedx86_64target inpacked_simd.