GH-49255: Fix pandas deprecation warnings in Categorical tests #49271
+13
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Python
Component: Documentation
awaiting review
rok
reviewed
Feb 13, 2026
docs/source/python/ipc.rst
Outdated
| print("LEN:", len(loaded_array)) | ||
| print("RSS: {}MB".format(pa.total_allocated_bytes() >> 20)) | ||
|
|
||
| Security considerations for untrusted IPC data |
Member
There was a problem hiding this comment.
@shashbha14 this is not related to Categorical tests. Would you like to update this PR?
Contributor
Author
There was a problem hiding this comment.
Thanks for catching that! I've removed the unrelated docs commit. The PR now only contains the pandas Categorical deprecation warnings fix.
github-actions
bot
added
awaiting changes
…H-49255) Replace pd.Categorical() calls that specify categories containing values not in the categories list with the recommended pattern: create the Categorical first, then use .set_categories() to restrict. Fixes deprecation warnings: - test_category: cat_strings_with_na - test_category_implicit_from_pandas: two Categorical instances Fixes apache#49255
shashbha14
force-pushed
the
gh-49255-fix-pandas-deprecation
branch
from
80babf4 to
ab9ee88
Compare
github-actions
bot
added
awaiting change review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the pandas deprecation warnings we're seeing in the test suite.
What was happening
Pandas started warning when you create a
Categoricalwith values that aren't in the categories list. We had a few places in the tests doing this:test_category: Creatingcat_strings_with_nawith categories['foo', 'bar']but the data includes'qux'test_category_implicit_from_pandas: Two places creating Categoricals with['a', 'b', 'c']but only allowing['a', 'b']in categoriesWhat I changed
Instead of passing
categoriesdirectly topd.Categorical(), I:.set_categories()to restrict it to what we wantThis is the recommended way to do it and avoids the warnings.
Testing
Fixes #49255