Skip to content

GH-49153: [C++] Remove deprecated decimal() factory function #49171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AliRana30 wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −15
Open

GH-49153: [C++] Remove deprecated decimal() factory function #49171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions cpp/src/arrow/type.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3345,11 +3345,6 @@ std::shared_ptr<Field> field(std::string name, std::shared_ptr<DataType> type,
std::move(metadata));
}

std::shared_ptr<DataType> decimal(int32_t precision, int32_t scale) {
return precision <= Decimal128Type::kMaxPrecision ? decimal128(precision, scale)
: decimal256(precision, scale);
}

std::shared_ptr<DataType> smallest_decimal(int32_t precision, int32_t scale) {
return precision <= Decimal32Type::kMaxPrecision ? decimal32(precision, scale)
: precision <= Decimal64Type::kMaxPrecision ? decimal64(precision, scale)
Expand Down
10 changes: 0 additions & 10 deletions cpp/src/arrow/type_fwd.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,16 +532,6 @@ ARROW_EXPORT const std::shared_ptr<DataType>& date64();
ARROW_EXPORT
std::shared_ptr<DataType> fixed_size_binary(int32_t byte_width);

/// \brief Create a DecimalType instance depending on the precision
///
/// If the precision is greater than 38, a Decimal256Type is returned,
/// otherwise a Decimal128Type.
///
/// Deprecated: prefer `smallest_decimal` instead.
ARROW_DEPRECATED("Deprecated in 18.0. Use `smallest_decimal` instead")
ARROW_EXPORT
std::shared_ptr<DataType> decimal(int32_t precision, int32_t scale);

/// \brief Create a the smallest DecimalType instance depending on precision
///
/// Given the requested precision and scale, the smallest DecimalType which
Expand Down
Loading