Skip to content

Conversation

@nateprewitt
Copy link
Contributor

@nateprewitt nateprewitt commented Feb 6, 2026

Rationale for this change

This PR is a follow up to #48971 and should address #44655. Previously, the C++ AzureFileSystem couldn't be compiled on Windows due to a incomplete type definition. Now that this has been resolved, we should be able to enable building on the Windows Platform for PyArrow as well.

What changes are included in this PR?

This PR sets the flags to enable building AzureFileSystem for PyArrow wheels on Windows. This will bring functionality in line with the Linux and macOS wheel builds.

Are these changes tested?

These changes enable existing testing that's used for other C++ Filesystems in PyArrow. Tests will validate the class is importable from the built wheels which seems to be the existing precedent. I can add other tests if needed, but will likely need some direction.

Are there any user-facing changes?

This PR will enable use of AzureFileSystem on Windows. Currently, trying to use or import the AzureFileSystem from PyArrow raises an ArrowNotImplementedError.

>>> from pyarrow.fs import AzureFileSystem
ImportError: The pyarrow installation is not built with support for 'AzureFileSystem'
>>> import pyarrow.fs as fs
>>> fs.FileSystem.from_uri('abfss://[email protected]/path')
pyarrow.lib.ArrowNotImplementedError: Got Azure Blob File System URI but Arrow compiled without Azure Blob File System support

After these changes, support should be available.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

⚠️ GitHub issue #44655 has been automatically assigned in GitHub to PR creator.

@nateprewitt
Copy link
Contributor Author

The one test failure is https://github.com/apache/arrow/actions/runs/21764368585/job/62795990526?pr=49170 which has already been timing out on main for a couple weeks.

@kou
Copy link
Member

kou commented Feb 7, 2026

@github-actions crossbow submit -g wheel

@github-actions

This comment was marked as outdated.

@nateprewitt
Copy link
Contributor Author

Thanks for checking the builds, @kou! It looks like I missed a feature flag in the dockerfile so we weren't getting the Azure C++ SDK in CI. That should hopefully be addressed in 92ebfcc.

@kou
Copy link
Member

kou commented Feb 8, 2026

@github-actions crossbow submit -g wheel

@github-actions

This comment was marked as outdated.

@nateprewitt
Copy link
Contributor Author

It looks like everything we'd expect to be passing is currently. Please let me know if we need anything else.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
Copy link
Member

kou commented Feb 11, 2026

@github-actions crossbow submit -g wheel

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Feb 11, 2026
@github-actions

This comment was marked as outdated.

Comment on lines 140 to 150
--x-feature=azure`
--x-feature=flight`
--x-feature=gcs`
--x-feature=json`
--x-feature=orc`
--x-feature=parquet`
--x-feature=azure `
--x-feature=flight `
--x-feature=gcs `
--x-feature=json `
--x-feature=orc `
--x-feature=parquet `
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--x-feature=azure`
--x-feature=flight`
--x-feature=gcs`
--x-feature=json`
--x-feature=orc`
--x-feature=parquet`
--x-feature=azure `
--x-feature=flight `
--x-feature=gcs `
--x-feature=json `
--x-feature=orc `
--x-feature=parquet `
--x-feature=azure `
--x-feature=flight`
--x-feature=gcs `
--x-feature=json `
--x-feature=orc `
--x-feature=parquet `

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Feb 11, 2026
@kou
Copy link
Member

kou commented Feb 11, 2026

@github-actions crossbow submit -g wheel

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Feb 11, 2026
@github-actions
Copy link

Revision: 3299689

Submitted crossbow builds: ursacomputing/crossbow @ actions-fc6389504b

Task Status
python-sdist GitHub Actions
wheel-macos-monterey-cp310-cp310-amd64 GitHub Actions
wheel-macos-monterey-cp310-cp310-arm64 GitHub Actions
wheel-macos-monterey-cp311-cp311-amd64 GitHub Actions
wheel-macos-monterey-cp311-cp311-arm64 GitHub Actions
wheel-macos-monterey-cp312-cp312-amd64 GitHub Actions
wheel-macos-monterey-cp312-cp312-arm64 GitHub Actions
wheel-macos-monterey-cp313-cp313-amd64 GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64 GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64 GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64 GitHub Actions
wheel-macos-monterey-cp314-cp314-amd64 GitHub Actions
wheel-macos-monterey-cp314-cp314-arm64 GitHub Actions
wheel-macos-monterey-cp314-cp314t-amd64 GitHub Actions
wheel-macos-monterey-cp314-cp314t-arm64 GitHub Actions
wheel-manylinux-2-28-cp310-cp310-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-cp310-arm64 GitHub Actions
wheel-manylinux-2-28-cp311-cp311-amd64 GitHub Actions
wheel-manylinux-2-28-cp311-cp311-arm64 GitHub Actions
wheel-manylinux-2-28-cp312-cp312-amd64 GitHub Actions
wheel-manylinux-2-28-cp312-cp312-arm64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64 GitHub Actions
wheel-manylinux-2-28-cp314-cp314-amd64 GitHub Actions
wheel-manylinux-2-28-cp314-cp314-arm64 GitHub Actions
wheel-manylinux-2-28-cp314-cp314t-amd64 GitHub Actions
wheel-manylinux-2-28-cp314-cp314t-arm64 GitHub Actions
wheel-musllinux-1-2-cp310-cp310-amd64 GitHub Actions
wheel-musllinux-1-2-cp310-cp310-arm64 GitHub Actions
wheel-musllinux-1-2-cp311-cp311-amd64 GitHub Actions
wheel-musllinux-1-2-cp311-cp311-arm64 GitHub Actions
wheel-musllinux-1-2-cp312-cp312-amd64 GitHub Actions
wheel-musllinux-1-2-cp312-cp312-arm64 GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64 GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64 GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64 GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64 GitHub Actions
wheel-musllinux-1-2-cp314-cp314-amd64 GitHub Actions
wheel-musllinux-1-2-cp314-cp314-arm64 GitHub Actions
wheel-musllinux-1-2-cp314-cp314t-amd64 GitHub Actions
wheel-musllinux-1-2-cp314-cp314t-arm64 GitHub Actions
wheel-windows-cp310-cp310-amd64 GitHub Actions
wheel-windows-cp311-cp311-amd64 GitHub Actions
wheel-windows-cp312-cp312-amd64 GitHub Actions
wheel-windows-cp313-cp313-amd64 GitHub Actions
wheel-windows-cp313-cp313t-amd64 GitHub Actions
wheel-windows-cp314-cp314-amd64 GitHub Actions
wheel-windows-cp314-cp314t-amd64 GitHub Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @nateprewitt ! Awesome addition!
Unrelated to this PR but maybe we could enable ARROW_AZURE on the following Windows PR CI job too, similar to how we do it on macOS builds on that same workflow.

windows:
name: AMD64 Windows 2022 Python 3.13

It would be great to get a PR for that too :)

@nateprewitt
Copy link
Contributor Author

Thanks @raulcd! I've put up #49240 to hopefully address that.

@kou kou merged commit 3fd809f into apache:main Feb 12, 2026
46 of 48 checks passed
@kou kou removed the awaiting merge Awaiting merge label Feb 12, 2026
kou pushed a commit that referenced this pull request Feb 12, 2026
### Rationale for this change
This PR is a follow up to #49170 at the request of @ raulcd. This enables Azure in the Python Windows build CI.

### What changes are included in this PR?

This change adds `ARROW_AZURE=ON` in the python_build.bat script and propagates it to cmake and pyarrow.

### Are these changes tested?
This is should enable full test runs for PyArrow in `python_test.bat`.

### Are there any user-facing changes?
No, this should be purely a CI update for testing.

Authored-by: Nate Prewitt <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants