-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-44655: [C++][Python] Enable building AzureFileSystem in PyArrow wheels on Windows #49170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
The one test failure is https://github.com/apache/arrow/actions/runs/21764368585/job/62795990526?pr=49170 which has already been timing out on main for a couple weeks. |
|
@github-actions crossbow submit -g wheel |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit -g wheel |
This comment was marked as outdated.
This comment was marked as outdated.
|
It looks like everything we'd expect to be passing is currently. Please let me know if we need anything else. |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
@github-actions crossbow submit -g wheel |
This comment was marked as outdated.
This comment was marked as outdated.
| --x-feature=azure` | ||
| --x-feature=flight` | ||
| --x-feature=gcs` | ||
| --x-feature=json` | ||
| --x-feature=orc` | ||
| --x-feature=parquet` | ||
| --x-feature=azure ` | ||
| --x-feature=flight ` | ||
| --x-feature=gcs ` | ||
| --x-feature=json ` | ||
| --x-feature=orc ` | ||
| --x-feature=parquet ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| --x-feature=azure` | |
| --x-feature=flight` | |
| --x-feature=gcs` | |
| --x-feature=json` | |
| --x-feature=orc` | |
| --x-feature=parquet` | |
| --x-feature=azure ` | |
| --x-feature=flight ` | |
| --x-feature=gcs ` | |
| --x-feature=json ` | |
| --x-feature=orc ` | |
| --x-feature=parquet ` | |
| --x-feature=azure ` | |
| --x-feature=flight` | |
| --x-feature=gcs ` | |
| --x-feature=json ` | |
| --x-feature=orc ` | |
| --x-feature=parquet ` |
|
@github-actions crossbow submit -g wheel |
|
Revision: 3299689 Submitted crossbow builds: ursacomputing/crossbow @ actions-fc6389504b |
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @nateprewitt ! Awesome addition!
Unrelated to this PR but maybe we could enable ARROW_AZURE on the following Windows PR CI job too, similar to how we do it on macOS builds on that same workflow.
arrow/.github/workflows/python.yml
Lines 243 to 244 in e11aeee
| windows: | |
| name: AMD64 Windows 2022 Python 3.13 |
It would be great to get a PR for that too :)
### Rationale for this change This PR is a follow up to #49170 at the request of @ raulcd. This enables Azure in the Python Windows build CI. ### What changes are included in this PR? This change adds `ARROW_AZURE=ON` in the python_build.bat script and propagates it to cmake and pyarrow. ### Are these changes tested? This is should enable full test runs for PyArrow in `python_test.bat`. ### Are there any user-facing changes? No, this should be purely a CI update for testing. Authored-by: Nate Prewitt <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
This PR is a follow up to #48971 and should address #44655. Previously, the C++ AzureFileSystem couldn't be compiled on Windows due to a incomplete type definition. Now that this has been resolved, we should be able to enable building on the Windows Platform for PyArrow as well.
What changes are included in this PR?
This PR sets the flags to enable building AzureFileSystem for PyArrow wheels on Windows. This will bring functionality in line with the Linux and macOS wheel builds.
Are these changes tested?
These changes enable existing testing that's used for other C++ Filesystems in PyArrow. Tests will validate the class is importable from the built wheels which seems to be the existing precedent. I can add other tests if needed, but will likely need some direction.
Are there any user-facing changes?
This PR will enable use of AzureFileSystem on Windows. Currently, trying to use or import the AzureFileSystem from PyArrow raises an ArrowNotImplementedError.
After these changes, support should be available.