Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44757: [GLib] Add garrow_array_validate() #45328

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

hiroyuki-sato
Copy link
Contributor

@hiroyuki-sato hiroyuki-sato commented Jan 22, 2025

Rationale for this change

Array::Validate available in the C++ API.
But, GLib doesn't support that method yet.

What changes are included in this PR?

This PR adds a validation method in the array class.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@hiroyuki-sato hiroyuki-sato requested a review from kou as a code owner January 22, 2025 04:23
Copy link

⚠️ GitHub issue #44757 has been automatically assigned in GitHub to PR creator.

c_glib/arrow-glib/basic-array.h Outdated Show resolved Hide resolved
c_glib/test/test-array.rb Outdated Show resolved Hide resolved
c_glib/test/test-array.rb Outdated Show resolved Hide resolved
c_glib/test/test-array.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jan 22, 2025
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 22, 2025
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 3a3f2ec into apache:main Jan 22, 2025
15 checks passed
@kou kou removed the awaiting change review Awaiting change review label Jan 22, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants