-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45316: [Release][C#] Use GitHub Releases for artifacts #45317
base: main
Are you sure you want to change the base?
Conversation
|
4c3b685
to
6aaa47d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kou for taking this effort. I've gone through all these changes and everything looks pretty good to me.
I had some minor questions but have been solved once I've gone through the whole changeset, so from my side this can be merged and tried.
The uploaded contents looks good:
Archive: nuget.zip
inflating: Apache.Arrow.20.0.0-dev-10.nupkg
inflating: Apache.Arrow.20.0.0-dev-10.nupkg.sha256
inflating: Apache.Arrow.20.0.0-dev-10.nupkg.sha512
inflating: Apache.Arrow.20.0.0-dev-10.snupkg
inflating: Apache.Arrow.20.0.0-dev-10.snupkg.sha256
inflating: Apache.Arrow.20.0.0-dev-10.snupkg.sha512
inflating: Apache.Arrow.Compression.20.0.0-dev-10.nupkg
inflating: Apache.Arrow.Compression.20.0.0-dev-10.nupkg.sha256
inflating: Apache.Arrow.Compression.20.0.0-dev-10.nupkg.sha512
inflating: Apache.Arrow.Compression.20.0.0-dev-10.snupkg
inflating: Apache.Arrow.Compression.20.0.0-dev-10.snupkg.sha256
inflating: Apache.Arrow.Compression.20.0.0-dev-10.snupkg.sha512
inflating: Apache.Arrow.Flight.20.0.0-dev-10.nupkg
inflating: Apache.Arrow.Flight.20.0.0-dev-10.nupkg.sha256
inflating: Apache.Arrow.Flight.20.0.0-dev-10.nupkg.sha512
inflating: Apache.Arrow.Flight.20.0.0-dev-10.snupkg
inflating: Apache.Arrow.Flight.20.0.0-dev-10.snupkg.sha256
inflating: Apache.Arrow.Flight.20.0.0-dev-10.snupkg.sha512
inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.nupkg
inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.nupkg.sha256
inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.nupkg.sha512
inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.snupkg
inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.snupkg.sha256
inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.snupkg.sha512
inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.nupkg
inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.nupkg.sha256
inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.nupkg.sha512
inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.snupkg
inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.snupkg.sha256
inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.snupkg.sha512
And the release changes to take those into account look also good.
I've also validated that the verify release script does not require changes (it will verify checksums correctly with the current changes).
I'm checking tagging cases in my fork...: https://github.com/kou/arrow/releases/tag/apache-arrow-20.0.0-rc0
|
I confirmed that the followings work well:
|
I'll merge this in a few days if nobody objects this. |
The GITHUB_TOKEN needs the |
Right. I've fixed this by it. |
Rationale for this change
We don't need to use Artifactory for NuGet packages because it's not published to Artifactory.
What changes are included in this PR?
.github/workflows/csharp.yml
instead of nightly job for easy to maintainAre these changes tested?
Almost yes.
Are there any user-facing changes?
No.