-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44515: [D] Add Initial Support #44536
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,104 @@ | ||||||
# Licensed to the Apache Software Foundation (ASF) under one | ||||||
# or more contributor license agreements. See the NOTICE file | ||||||
# distributed with this work for additional information | ||||||
# regarding copyright ownership. The ASF licenses this file | ||||||
# to you under the Apache License, Version 2.0 (the | ||||||
# "License"); you may not use this file except in compliance | ||||||
# with the License. You may obtain a copy of the License at | ||||||
# | ||||||
# http://www.apache.org/licenses/LICENSE-2.0 | ||||||
# | ||||||
# Unless required by applicable law or agreed to in writing, | ||||||
# software distributed under the License is distributed on an | ||||||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||||||
# KIND, either express or implied. See the License for the | ||||||
# specific language governing permissions and limitations | ||||||
# under the License. | ||||||
|
||||||
name: D | ||||||
|
||||||
on: | ||||||
push: | ||||||
branches: | ||||||
- '**' | ||||||
- '!dependabot/**' | ||||||
tags: | ||||||
- '**' | ||||||
paths: | ||||||
- '.dockerignore' | ||||||
- '.github/workflows/d.yml' | ||||||
- 'ci/docker/*d*' | ||||||
- 'ci/scripts/c_glib_*' | ||||||
- 'ci/scripts/cpp_*' | ||||||
- 'ci/scripts/d_*' | ||||||
- 'c_glib/**' | ||||||
- 'cpp/**' | ||||||
- 'docker-compose.yml' | ||||||
- 'd/**' | ||||||
pull_request: | ||||||
paths: | ||||||
- '.dockerignore' | ||||||
- '.github/workflows/d.yml' | ||||||
- 'ci/docker/*d*' | ||||||
- 'ci/scripts/c_glib_*' | ||||||
- 'ci/scripts/cpp_*' | ||||||
- 'ci/scripts/d_*' | ||||||
- 'c_glib/**' | ||||||
- 'cpp/**' | ||||||
- 'docker-compose.yml' | ||||||
- 'd/**' | ||||||
|
||||||
concurrency: | ||||||
group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }} | ||||||
cancel-in-progress: true | ||||||
|
||||||
permissions: | ||||||
contents: read | ||||||
|
||||||
env: | ||||||
ARCHERY_DEBUG: 1 | ||||||
DOCKER_VOLUME_PREFIX: ".docker/" | ||||||
|
||||||
jobs: | ||||||
docker: | ||||||
name: AMD64 Ubuntu ${{ matrix.ubuntu }} Glib & D | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
runs-on: ubuntu-latest | ||||||
if: ${{ !contains(github.event.pull_request.title, 'WIP') }} | ||||||
timeout-minutes: 60 | ||||||
strategy: | ||||||
fail-fast: false | ||||||
matrix: | ||||||
ubuntu: | ||||||
- 22.04 | ||||||
env: | ||||||
UBUNTU: ${{ matrix.ubuntu }} | ||||||
steps: | ||||||
- name: Checkout Arrow | ||||||
uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
with: | ||||||
fetch-depth: 0 | ||||||
submodules: recursive | ||||||
- name: Setup Python on hosted runner | ||||||
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0 | ||||||
with: | ||||||
python-version: 3 | ||||||
- name: Setup Archery | ||||||
run: pip install -e dev/archery[docker] | ||||||
- name: Execute Docker Build | ||||||
env: | ||||||
ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }} | ||||||
ARCHERY_DOCKER_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }} | ||||||
run: | | ||||||
source ci/scripts/util_enable_core_dumps.sh | ||||||
archery docker run ubuntu-d | ||||||
- name: Docker Push | ||||||
if: >- | ||||||
success() && | ||||||
github.event_name == 'push' && | ||||||
github.repository == 'apache/arrow' && | ||||||
github.ref_name == 'main' | ||||||
env: | ||||||
ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }} | ||||||
ARCHERY_DOCKER_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }} | ||||||
continue-on-error: true | ||||||
run: archery docker push ubuntu-d |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you rename this to Lines 853 to 875 in 33e8cbb
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
ARG base | ||
FROM ${base} | ||
|
||
SHELL ["/bin/bash", "-o", "pipefail", "-c"] | ||
|
||
RUN echo "debconf debconf/frontend select Noninteractive" | | ||
debconf-set-selections | ||
|
||
# Install ldc2 toolchain (dmd-frontend + llvm-backend), dub package manager & meson build system | ||
RUN apt-get update -y -q && | ||
apt-get install -y -q --no-install-recommends \ | ||
dub \ | ||
ldc \ | ||
meson \ | ||
pkg-config && | ||
apt-get clean && \ | ||
rm -rf /var/lib/apt/lists/* |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
#!/usr/bin/env bash | ||
# | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
set -ex | ||
|
||
source_dir=${1}/d | ||
|
||
export DYLD_LIBRARY_PATH=${ARROW_HOME}/lib:${DYLD_LIBRARY_PATH} | ||
export LD_LIBRARY_PATH=${ARROW_HOME}/lib:${LD_LIBRARY_PATH} | ||
export PKG_CONFIG_PATH=${ARROW_HOME}/lib/pkgconfig | ||
export GI_TYPELIB_PATH=${ARROW_HOME}/lib/girepository-1.0 | ||
|
||
# Enable memory debug checks if the env is not set already | ||
if [ -z "${ARROW_DEBUG_MEMORY_POOL}" ]; then | ||
export ARROW_DEBUG_MEMORY_POOL=trap | ||
fi | ||
|
||
dub test --root=${source_dir} |
kassane marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
# unittest executable | ||
arrow-d-test-unittest* | ||
# generated files | ||
source/arrow*/ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
<!--- | ||
Licensed to the Apache Software Foundation (ASF) under one | ||
or more contributor license agreements. See the NOTICE file | ||
distributed with this work for additional information | ||
regarding copyright ownership. The ASF licenses this file | ||
to you under the Apache License, Version 2.0 (the | ||
"License"); you may not use this file except in compliance | ||
with the License. You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, | ||
software distributed under the License is distributed on an | ||
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
KIND, either express or implied. See the License for the | ||
specific language governing permissions and limitations | ||
under the License. | ||
--> | ||
|
||
# Apache Arrow D | ||
|
||
An implementation of Arrow targeting D programming language. | ||
|
||
See our current [feature matrix](https://github.com/apache/arrow/blob/main/docs/source/status.rst) | ||
for currently available features. | ||
|
||
## Requirements | ||
|
||
- [dmd/gdc/ldc2](https://dlang.org/download) with druntime-frontend 2.105.0 or later | ||
|
||
## Building | ||
|
||
- build Apache Arrow C++ | ||
- build Apache Arrow GLib | ||
- build D bindings | ||
|
||
```console | ||
$ git clone https://github.com/apache/arrow.git | ||
$ cd arrow/d | ||
$ dub build -b release | ||
# Test | ||
$ dub test | ||
``` |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can't add license header to this file because this is JSON, right? |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
{ | ||
"name": "arrow-d", | ||
"description": "Apache Arrow - D bindings", | ||
"license": "Apache-2.0", | ||
"toolchainRequirements": { | ||
"frontend": ">=2.105.3" | ||
}, | ||
"buildTypes": { | ||
"debug": { | ||
"buildOptions": [ | ||
"debugMode", | ||
"debugInfo" | ||
] | ||
}, | ||
"release": { | ||
"buildOptions": [ | ||
"releaseMode", | ||
"inline", | ||
"optimize" | ||
] | ||
} | ||
}, | ||
"preBuildCommands": [ | ||
"\"$DUB\" run girtod -- -i source -o source --use-runtime-linker" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we use out-of-source build? |
||
], | ||
"dependencies": { | ||
"girtod": { | ||
"repository": "git+https://github.com/gtkd-developers/gir-to-d.git", | ||
"version": "098475152340cbac072824af5136b9151a983ca4" | ||
}, | ||
"glibd": { | ||
"repository": "git+https://github.com/gtkd-developers/GlibD.git", | ||
"version": "1546823185334c4727d378baf890fa13d9fa4cbd" | ||
} | ||
}, | ||
"configurations": [ | ||
{ | ||
"name": "unittest", | ||
"sourceFiles": [ | ||
"source/package.d" | ||
], | ||
"libs": [ | ||
"arrow-glib" | ||
], | ||
"dflags-dmd": ["-verrors=context"], | ||
"dflags-ldc": ["--verrors-context"] | ||
} | ||
] | ||
|
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
includeComments: y | ||
|
||
lookup: APILookupArrow.txt |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
# add apache license in wrapped modules | ||
|
||
license: start | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
// generated automatically - do not change | ||
// find conversion definition on APILookup.txt | ||
// implement new conversion functionalities the gir-to-d package | ||
|
||
|
||
license: end | ||
|
||
############################################# | ||
### Definitions for wrapping Arrow ########## | ||
############################################# | ||
|
||
wrap: arrow | ||
file: Arrow-1.0.gir | ||
|
||
# rename | ||
alias: import import_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All
.dockerfile
s are matched...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kou,
I have not listed the
d/
files in.dockerignore
.One question: is docker_ruby already included in c_glib?
Previously the CI/CD section, I just attempted adapting swift-lang recipe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is referred by the
docker_ruby
? https://github.com/apache/arrow/blob/main/ci/docker/linux-apt-ruby.dockerfile ?