Bump pyo3 to 0.26.0 #8286
Open
Bump pyo3 to 0.26.0 #8286
+36
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrobbel
added
api-change
kylebarron
approved these changes
Sep 5, 2025
| @@ -41,7 +41,7 @@ fn to_py_err(err: ArrowError) -> PyErr { | |||
|
|
|||
| /// Returns `array + array` of an int64 array. | |||
| #[pyfunction] | |||
| fn double(array: &Bound<PyAny>, py: Python) -> PyResult<PyObject> { | |||
| fn double(array: &Bound<PyAny>, py: Python) -> PyResult<Py<PyAny>> { | |||
There was a problem hiding this comment.
It may make sense to change the return type of the to_pyarrow functions to Bound<PyAny> instead of Py<PyAny>? Then you wouldn't need to carry around a py: Python token in any of these functions.
There was a problem hiding this comment.
Is 5218810 what you had in mind?
alamb
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Bumping to the latest pyo3.
What changes are included in this PR?
Handle breaking changes.
Are these changes tested?
CI.
Are there any user-facing changes?
Yes.