feat: SSLKEYLOGFILE support for flight CLI
#8239
Merged
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
crepererum
force-pushed
the
crepererum/flight-client-sslkeylog-2
branch
from
9e208fe to
18194d6
Compare
mbrobbel
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
-
Rationale for this change
This is #4875 now that the upstream changes are available.
Allows analysis of TLS traffic with an external tool like Wireshark.
See https://wiki.wireshark.org/TLS#using-the-pre-master-secret
What changes are included in this PR?
New flag that opts into into the standard
SSLKEYLOGFILEhandling that other libraries and browsers support.Are these changes tested?
Not automatic test, but I did validate that setting the flag AND the env variable emits a log file that is successfully used by Wireshark to decrypt the traffic.
Are there any user-facing changes?
Mostly none for normal users, but might be helpful for developers.