Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
peek_next_page_offset
toSerializedPageReader
#6945Add
peek_next_page_offset
toSerializedPageReader
#6945Changes from 1 commit
53bcfc0
7804621
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my only real concern is the fact that this body has so much duplication with
peek_next_page
(especially in the SerializedPageReaderState::Values block)it is also somewhat strange it is in a different
impl
block thanpeek_next_page
(I would have expected it to be next to it) but maybe I missed some generic subtletyI tried a few ways to avoid the duplication and I didn't really find any good way to do so,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, I tried to make
peek_next_page
to return an offset as well, but has no luck to easily do it.I think it's because
peek_next_page
is inPageReader
trait