fix(csharp/test/Drivers/Databricks): Fix SendAsync_WithExternalToken_BlocksUntilTokenExchangeCompletes #3755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix flaky test by using the more-accurate `Stopwatch` instead of `DateTime.UtcNow`.
Contributor
Author
|
Okay, so my theory about the test failure is wrong... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky test SendAsync_WithExternalToken_BlocksUntilTokenExchangeCompletes by using the more-accurate
Stopwatchinstead ofDateTime.UtcNow. The latter was regularly causing test failures with messages like "Request took 488.5696ms, which is shorter than the token exchange delay of 500ms. Expected blocking behavior." due to the lack of precision.