-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARIES-2160 - Simple MBeanServer based on the platform implementation #296
Open
rombert
wants to merge
3
commits into
apache:trunk
Choose a base branch
from
rombert:issue/ARIES-2160
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alien11689
reviewed
Nov 27, 2024
...server-platform/src/main/java/org/apache/aries/jmx/mbean_server/platform/impl/Activator.java
Show resolved
Hide resolved
Ah, very interesting. Maybe the OSGi framework used by the tests does not support Java 8?
…On November 29, 2024 5:57:42 PM GMT+01:00, Dominik Przybysz ***@***.***> wrote:
@alien11689 commented on this pull request.
> +import javax.management.Attribute;
+import javax.management.AttributeList;
+import javax.management.MBeanServer;
+import javax.management.ObjectName;
+
+import org.osgi.framework.BundleActivator;
+import org.osgi.framework.BundleContext;
+import org.osgi.framework.ServiceRegistration;
+
+public class Activator implements BundleActivator {
+
+ private final Object registrationLock = new Object();
+ private ServiceRegistration<MBeanServer> registration;
+
+ @OverRide
+ public void start(BundleContext context) throws Exception {
I was able to have green build locally with some hacky way...
```
$ rm -r ~/.m2/repository/
$ git llog | head -5
6629195 2024-11-26 16:45:57 +0100 Christian Schneider (HEAD -> trunk, origin/trunk, origin/HEAD) Merge pull request #295 from rombert/fix/jmx-parent-update
7ad81cb 2024-11-26 15:41:01 +0100 Robert Munteanu jmx: use Aries parent 2.1.1
e93c801 2023-11-14 22:16:29 +0100 Guillaume Nodet Fix javadoc
aea7d90 2023-11-07 20:56:47 +0100 JB Onofré [maven-release-plugin] prepare for next development iteration
e9086cb 2023-11-07 20:56:32 +0100 JB Onofré (tag: spifly-1.3.7) [maven-release-plugin] prepare release spifly-1.3.7
$ mvn -pl jmx/jmx-itests clean install
...
$ git checkout e93c801
...
$ mvn -am -pl jmx/jmx-bundle clean install
...
$ git checkout trunk
...
# update pax url to 2.5.3 in itest pom.xml
...
$ mvn -pl jmx/jmx-itests clean install # note: no -am
```
It looks like jmx-bundle built with newer parent makes the tests fail.
I see the only one significant difference in jmx-bundle jars -
```
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.6))"
```
is changed to
```
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))"
```
--
Reply to this email directly or view it on GitHub:
#296 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
rombert
force-pushed
the
issue/ARIES-2160
branch
from
December 9, 2024 12:45
cfb272b
to
ea9a7a2
Compare
rombert
force-pushed
the
issue/ARIES-2160
branch
from
December 16, 2024 16:11
c43e03e
to
0238d50
Compare
Add jmx-mbeanserver-platform bundle
Add jmx-mbeanserver-platform to the jmx reactor pom
Use the new MBeanServer Platform bundle in the ITs
rombert
force-pushed
the
issue/ARIES-2160
branch
from
December 16, 2024 16:15
0238d50
to
6966c3d
Compare
@alien11689 - I have added the new bundle to the ITs and now its |
alien11689
approved these changes
Dec 17, 2024
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the module and registered it in the JMX reactor.