-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: aws-auth plugin #11595
base: master
Are you sure you want to change the base?
feat: aws-auth plugin #11595
Conversation
My first lua PR. Please tell me what else needs to be done. And How to. Thanks. |
@Lensual nice work, I will ask more committers to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are the practical use cases for this PR? I see some test cases are failing, please fix them. Also, please include docs that shows how to use this plugin. Once you have done this please mark this PR "ready for review"
6f0f95d
to
aaa0b1d
Compare
Description
Implementing the AWS Signature v4 authentication plugin.
Checklist
Attributes
For Consumer:
NOTE:
encrypt_fields = {"access_key", "secret_key"}
is also defined in the schema, which means that the field will be stored encrypted in etcd. See encrypted storage fields.For Route:
X-Amz-Date
is not in request parameter, an error will occur. Setting it to 0 will skip checking the date (UNSAFE).X-Amz-Expires
parameter. The default value is 604800 seconds (7 days). Setting it to 0 will skip checking exprires limit (UNSAFE).