Skip to content

[Refactor] Introduce Iceberg TableRuntimePlugin#4073

Open
majin1102 wants to merge 2 commits intoapache:masterfrom
majin1102:tableruntimeplugin
Open

[Refactor] Introduce Iceberg TableRuntimePlugin#4073
majin1102 wants to merge 2 commits intoapache:masterfrom
majin1102:tableruntimeplugin

Conversation

@majin1102
Copy link
Contributor

@majin1102 majin1102 commented Feb 2, 2026

Why are the changes needed?

Refactoring work for format processing extensions

Brief change log

  1. Abstract TableRuntimePlugin to extend lance table runtime processing
  2. Refactor DefaultTableService to abstract a IcebergTablePlugin which implements TableRuntimeHandler(only aimed for Iceberg table)

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@majin1102 majin1102 requested a review from baiyangtx February 2, 2026 16:40
@majin1102 majin1102 force-pushed the tableruntimeplugin branch 3 times, most recently from 0f1a1a0 to 40120af Compare February 5, 2026 11:58
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.39%. Comparing base (869860e) to head (f3606a6).
⚠️ Report is 8 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (869860e) and HEAD (f3606a6). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (869860e) HEAD (f3606a6)
core 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4073      +/-   ##
============================================
- Coverage     28.63%   22.39%   -6.24%     
+ Complexity     3942     2552    -1390     
============================================
  Files           654      458     -196     
  Lines         52293    42116   -10177     
  Branches       6621     5917     -704     
============================================
- Hits          14973     9433    -5540     
+ Misses        36230    31871    -4359     
+ Partials       1090      812     -278     
Flag Coverage Δ
core ?
trino 22.39% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants