[FEATURE]Support Dynamic Config.#4072
Open
LiangDai-Mars wants to merge 2 commits intoapache:masterfrom
Open
Conversation
baiyangtx
requested changes
Feb 5, 2026
| * @param properties plugin properties | ||
| * @param configurationManager configuration manager used to fetch dynamic overrides | ||
| */ | ||
| default void open(Map<String, String> properties, ConfigurationManager configurationManager) { |
Contributor
There was a problem hiding this comment.
I suggest using void open(Configuration configs) instead.
| * Configurations} is expected. All getter methods defined in {@link Configurations} operate on the | ||
| * current merged configuration. | ||
| */ | ||
| public class DynamicConfigurations extends Configurations { |
Contributor
There was a problem hiding this comment.
DynamicConfigurations and ConfigurationManager should be in ams module.
Comment on lines
+96
to
+101
| public TerminalManager( | ||
| org.apache.amoro.config.DynamicConfigurations dynamicConfigurations, | ||
| CatalogManager catalogManager) { | ||
| this((Configurations) dynamicConfigurations, catalogManager); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
- No need type casting.
- Import at file head.
| } | ||
|
|
||
| public ProcessService( | ||
| org.apache.amoro.config.DynamicConfigurations dynamicConfigurations, |
Contributor
There was a problem hiding this comment.
Import class at file head.
Comment on lines
80
to
+82
| public AbstractPluginManager(String pluginCategory) { | ||
| this(pluginCategory, null, null); | ||
| } |
Contributor
There was a problem hiding this comment.
I think this constructor may should be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #xxx.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation