Fixed the issue where the process table was completed after AMS restart, but the table status remained in the running state.#4043
Open
lintingbin wants to merge 2 commits intoapache:masterfrom
Conversation
… did not recover after AMS pod restart
klion26
reviewed
Feb 6, 2026
Member
klion26
left a comment
klion26
left a comment
There was a problem hiding this comment.
@lintingbin Thanks for the contribution, the change all over looks good to me, let one minor comment, please let me know what do you think.
| mapper -> mapper.getProcessState(tableRuntime.getProcessId())); | ||
| process = new TableOptimizingProcess(tableRuntime, meta, state); | ||
| tableRuntime.recover(process); | ||
| if (process.getStatus() == ProcessStatus.SUCCESS) { |
Member
There was a problem hiding this comment.
Will place this logic in tableRuntime.recover(process) be better?
Contributor
Author
There was a problem hiding this comment.
That makes sense, I've made the changes
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/OptimizingQueue.java
Show resolved
Hide resolved
klion26
approved these changes
Feb 6, 2026
Member
klion26
left a comment
klion26
left a comment
There was a problem hiding this comment.
Thanks for the quick update, LGTM, will merge it in next week if there are no more comments from the community.
lintingbin
commented
Feb 6, 2026
Comment on lines
142
to
143
| process = new TableOptimizingProcess(tableRuntime, meta, state); | ||
| tableRuntime.recover(process); |
Contributor
Author
There was a problem hiding this comment.
@klion26 Do you know why there is also tableRuntime.recover in the initialization function of TableOptimizingProcess? It looks a bit strange, doesn't it? Maybe we should optimize it?
if (this.status != ProcessStatus.KILLED) {
tableRuntime.recover(this);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #4041.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation