[AMORO-3989] Amoro's support for the domestic database Damang#3992
[AMORO-3989] Amoro's support for the domestic database Damang#3992linjianchang wants to merge 1 commit intoapache:masterfrom
Conversation
xxubai
left a comment
There was a problem hiding this comment.
Can you fix the unit tests
93d8588 to
1657fb5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3992 +/- ##
============================================
- Coverage 22.12% 7.80% -14.33%
+ Complexity 2461 895 -1566
============================================
Files 445 639 +194
Lines 40897 51508 +10611
Branches 5767 6545 +778
============================================
- Hits 9050 4019 -5031
- Misses 31089 47233 +16144
+ Partials 758 256 -502
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
91da4a4 to
7c134d5
Compare
| <dependency> | ||
| <groupId>com.dameng</groupId> | ||
| <artifactId>DmJdbcDriver18</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
I don’t think Dameng needs to be included in the release. Similar to MySQL, users who need it can add the JDBC dependency manually, rather than having it as a standard component.
There was a problem hiding this comment.
I don’t think Dameng needs to be included in the release. Similar to MySQL, users who need it can add the JDBC dependency manually, rather than having it as a standard component.
Aleady modified!
There was a problem hiding this comment.
@xxubai Thanks for your review. Do you have any other suggestions
7c134d5 to
6b2aa2d
Compare
a106090 to
99a9f0d
Compare
|
Adding support for other database connectors is technically straightforward. However, the primary concern is long-term maintenance. Is there sufficient community interest and commitment to help maintain this connector over time? I would like to invite more community members to participate in the discussion. @zhoujinsong @czy006 @Aireed |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions. |

[AMORO-3989] Amoro's support for the domestic database Damang