[Hotfix] Fetch the latest MemoryUsage inside each gauge call#4062
Merged
xxubai merged 1 commit intoapache:masterfrom Jan 29, 2026
Merged
[Hotfix] Fetch the latest MemoryUsage inside each gauge call#4062xxubai merged 1 commit intoapache:masterfrom
xxubai merged 1 commit intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4062 +/- ##
============================================
- Coverage 28.79% 28.64% -0.16%
+ Complexity 3944 3935 -9
============================================
Files 657 653 -4
Lines 52431 52276 -155
Branches 6664 6622 -42
============================================
- Hits 15098 14972 -126
+ Misses 36226 36211 -15
+ Partials 1107 1093 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xxubai
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Brief change log
The registerHeapMetric method only reads the JVM heap usage once at registration time and then reuses that snapshot inside the gauges, which causes the heap metrics to never change after being registered.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation