Skip to content

Commit 7b60ba5

Browse files
committed
[Hotfix] Fetch the latest MemoryUsage inside each gauge call.
1 parent cad9869 commit 7b60ba5

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

amoro-ams/src/main/java/org/apache/amoro/server/AmsServiceMetrics.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
import java.lang.management.GarbageCollectorMXBean;
3232
import java.lang.management.ManagementFactory;
33-
import java.lang.management.MemoryUsage;
33+
import java.lang.management.MemoryMXBean;
3434
import java.util.Collections;
3535
import java.util.List;
3636
import java.util.Map;
@@ -108,16 +108,16 @@ public void unregister() {
108108
}
109109

110110
private void registerHeapMetric() {
111-
MemoryUsage heapMemoryUsage = ManagementFactory.getMemoryMXBean().getHeapMemoryUsage();
111+
MemoryMXBean memoryMXBean = ManagementFactory.getMemoryMXBean();
112112
registerMetric(
113-
registry, AMS_JVM_MEMORY_HEAP_USED, (Gauge<Long>) () -> heapMemoryUsage.getUsed());
113+
registry, AMS_JVM_MEMORY_HEAP_USED, (Gauge<Long>) () -> memoryMXBean.getHeapMemoryUsage().getUsed());
114114

115115
registerMetric(
116116
registry,
117117
AMS_JVM_MEMORY_HEAP_COMMITTED,
118-
(Gauge<Long>) () -> heapMemoryUsage.getCommitted());
118+
(Gauge<Long>) () -> memoryMXBean.getHeapMemoryUsage().getCommitted());
119119

120-
registerMetric(registry, AMS_JVM_MEMORY_HEAP_MAX, (Gauge<Long>) () -> heapMemoryUsage.getMax());
120+
registerMetric(registry, AMS_JVM_MEMORY_HEAP_MAX, (Gauge<Long>) () -> memoryMXBean.getHeapMemoryUsage().getMax());
121121
}
122122

123123
private void registerThreadMetric() {

0 commit comments

Comments
 (0)