Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breeze command hashes to "Linux" version. #45155

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 22, 2024

When calculating command hashes, after click 1.8.1 the hash calculated is different for Linux than for Mac.

Until we fix it, setting it to Linux hashes is good for CI to not fail


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

When calculating command hashes, after click 1.8.1 the hash calculated
is different for Linux than for Mac.

Until we fix it, setting it to Linux hashes is good for CI to not fail
@potiuk
Copy link
Member Author

potiuk commented Dec 22, 2024

I will take a close look what has changed eventually but evidently on Mac the hash is different :)

@potiuk
Copy link
Member Author

potiuk commented Dec 22, 2024

(or at least it looks like - it also might be that there is other factor that makes it flip-flop).

@potiuk potiuk merged commit 24ce4f4 into apache:main Dec 22, 2024
19 checks passed
@potiuk potiuk deleted the fix-hashes-to-linux branch December 22, 2024 15:43
@gopidesupavan
Copy link
Member

I got it i think its the ubuntu upgrade that github release recently ? ubuntu-24.04. might it is default now in our repo

@gopidesupavan
Copy link
Member

Our CI using now the latest version ubuntu-24.04, https://github.com/apache/airflow/actions/runs/12454695812/job/34766359224#step:1:4

@potiuk
Copy link
Member Author

potiuk commented Dec 22, 2024

I got it i think its the ubuntu upgrade that github release recently ? ubuntu-24.04. might it is default now in our repo

Naa. Something else - I see a very weird behaviour on my Mac - the hash is changing between runs, so that's something different.

@potiuk
Copy link
Member Author

potiuk commented Dec 22, 2024

It looks like it's just NOT STABLE - but I haven't figured out yet what triggers the unstability.

@gopidesupavan
Copy link
Member

I got it i think its the ubuntu upgrade that github release recently ? ubuntu-24.04. might it is default now in our repo

Naa. Something else - I see a very weird behaviour on my Mac - the hash is changing between runs, so that's something different.

oh okay..

@potiuk
Copy link
Member Author

potiuk commented Dec 22, 2024

Yeah... It flip-flops randomly so we will keep on seing it... very interesting :)

@potiuk
Copy link
Member Author

potiuk commented Dec 22, 2024

Ok. Found it - new click does not keep stable sequence of options:

Screenshot 2024-12-22 at 16 59 21

@potiuk
Copy link
Member Author

potiuk commented Dec 22, 2024

Fix here: #45156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants