-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix breeze command hashes to "Linux" version. #45155
Conversation
When calculating command hashes, after click 1.8.1 the hash calculated is different for Linux than for Mac. Until we fix it, setting it to Linux hashes is good for CI to not fail
I will take a close look what has changed eventually but evidently on Mac the hash is different :) |
(or at least it looks like - it also might be that there is other factor that makes it flip-flop). |
I got it i think its the ubuntu upgrade that github release recently ? ubuntu-24.04. might it is default now in our repo |
Our CI using now the latest version ubuntu-24.04, https://github.com/apache/airflow/actions/runs/12454695812/job/34766359224#step:1:4 |
Naa. Something else - I see a very weird behaviour on my Mac - the hash is changing between runs, so that's something different. |
It looks like it's just NOT STABLE - but I haven't figured out yet what triggers the unstability. |
oh okay.. |
Yeah... It flip-flops randomly so we will keep on seing it... very interesting :) |
Fix here: #45156 |
When calculating command hashes, after click 1.8.1 the hash calculated is different for Linux than for Mac.
Until we fix it, setting it to Linux hashes is good for CI to not fail
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.