-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom dag_folder not settings.DAGS_FOLDER for FileLoadStat #45073
base: main
Are you sure you want to change the base?
Use custom dag_folder not settings.DAGS_FOLDER for FileLoadStat #45073
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
3518cfd
to
ba11246
Compare
I would love to write a test but for the life of me I can't find a tl;dr on how to run the dagbag tests quickly and locally without any Docker breeze. I would have expected this to simply be: conda create -n airflow python==3.12
pip install -e .[devel]
pytest tests/models/test_dagbag.py::test_dagbag_dag_collection |
@radujica We switched to uv recently. Something like this should work
|
TL;DR; is directly there in the contributing docs BTW: https://github.com/apache/airflow/blob/main/contributing-docs/07_local_virtualenv.rst |
Also @ashb - not sure if you know but |
|
Thank you for the swift input both :) Had lazily assumed I could just use uv venv
uv sync --extra devel
uv run pytest tests/models/test_dagbag.py::TestDagBag::test_dagbag_dag_collection Never used Anyway, will update PR with test soon enough. |
ba11246
to
c56a5d1
Compare
c56a5d1
to
80bc2f9
Compare
The stats would still use
settings.DAGS_FOLDER
despite dag_folder arg being set to a different path and used for the actual dags parsing.