-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dry run for backfill #45062
Open
prabhusneha
wants to merge
6
commits into
apache:main
Choose a base branch
from
astronomer:backfill_dry_run
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+249
−19
Open
Add dry run for backfill #45062
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a7a1efd
Add dry run for backfill
d288934
Add dry run for backfill
5bd604e
Add tests for backfill dry runs
23b7b9b
Fix tests
51e15bd
Merge remote-tracking branch 'origin/backfill_dry_run' into backfill_…
723beda
Merge branch 'main' into backfill_dry_run
prabhusneha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,7 @@ | |
from typing import Annotated | ||
|
||
from fastapi import Depends, HTTPException, status | ||
from sqlalchemy import select, update | ||
from sqlalchemy import desc, select, update | ||
|
||
from airflow.api_fastapi.common.db.common import ( | ||
AsyncSessionDep, | ||
|
@@ -30,8 +30,10 @@ | |
from airflow.api_fastapi.common.router import AirflowRouter | ||
from airflow.api_fastapi.core_api.datamodels.backfills import ( | ||
BackfillCollectionResponse, | ||
BackfillDryRunResponse, | ||
BackfillPostBody, | ||
BackfillResponse, | ||
BackfillRunInfo, | ||
) | ||
from airflow.api_fastapi.core_api.openapi.exceptions import ( | ||
create_openapi_http_exception_doc, | ||
|
@@ -41,9 +43,14 @@ | |
AlreadyRunningBackfill, | ||
Backfill, | ||
BackfillDagRun, | ||
BackfillDagRunExceptionReason, | ||
ReprocessBehavior, | ||
_create_backfill, | ||
_get_info_list, | ||
) | ||
from airflow.models.serialized_dag import SerializedDagModel | ||
from airflow.utils import timezone | ||
from airflow.utils.sqlalchemy import nulls_first | ||
from airflow.utils.state import DagRunState | ||
|
||
backfills_router = AirflowRouter(tags=["Backfill"], prefix="/backfills") | ||
|
@@ -187,22 +194,62 @@ def cancel_backfill(backfill_id, session: SessionDep) -> BackfillResponse: | |
) | ||
def create_backfill( | ||
backfill_request: BackfillPostBody, | ||
) -> BackfillResponse: | ||
session: SessionDep, | ||
) -> BackfillResponse | BackfillDryRunResponse: | ||
from_date = timezone.coerce_datetime(backfill_request.from_date) | ||
to_date = timezone.coerce_datetime(backfill_request.to_date) | ||
try: | ||
backfill_obj = _create_backfill( | ||
dag_id=backfill_request.dag_id, | ||
if not backfill_request.dry_run: | ||
try: | ||
backfill_obj = _create_backfill( | ||
dag_id=backfill_request.dag_id, | ||
from_date=from_date, | ||
to_date=to_date, | ||
max_active_runs=backfill_request.max_active_runs, | ||
reverse=backfill_request.run_backwards, | ||
dag_run_conf=backfill_request.dag_run_conf, | ||
reprocess_behavior=backfill_request.reprocess_behavior, | ||
) | ||
return BackfillResponse.model_validate(backfill_obj) | ||
except AlreadyRunningBackfill: | ||
raise HTTPException( | ||
status_code=status.HTTP_409_CONFLICT, | ||
detail=f"There is already a running backfill for dag {backfill_request.dag_id}", | ||
) | ||
else: | ||
serdag = session.scalar(SerializedDagModel.latest_item_select_object(backfill_request.dag_id)) | ||
if not serdag: | ||
raise HTTPException(status_code=404, detail=f"Could not find dag {backfill_request.dag_id}") | ||
|
||
info_list = _get_info_list( | ||
dag=serdag.dag, | ||
from_date=from_date, | ||
to_date=to_date, | ||
max_active_runs=backfill_request.max_active_runs, | ||
reverse=backfill_request.run_backwards, | ||
dag_run_conf=backfill_request.dag_run_conf, | ||
reprocess_behavior=backfill_request.reprocess_behavior, | ||
) | ||
return BackfillResponse.model_validate(backfill_obj) | ||
except AlreadyRunningBackfill: | ||
raise HTTPException( | ||
status_code=status.HTTP_409_CONFLICT, | ||
detail=f"There is already a running backfill for dag {backfill_request.dag_id}", | ||
) | ||
backfill_response_item = [] | ||
print(info_list) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to remove print statements |
||
for info in info_list: | ||
print(info.logical_date) | ||
dr = session.scalar( | ||
select(DagRun) | ||
.where(DagRun.logical_date == info.logical_date) | ||
.order_by(nulls_first(desc(DagRun.start_date), session)) | ||
.limit(1) | ||
) | ||
|
||
if dr: | ||
non_create_reason = None | ||
if dr.state not in (DagRunState.SUCCESS, DagRunState.FAILED): | ||
non_create_reason = BackfillDagRunExceptionReason.IN_FLIGHT | ||
elif backfill_request.reprocess_behavior is ReprocessBehavior.NONE: | ||
non_create_reason = BackfillDagRunExceptionReason.ALREADY_EXISTS | ||
elif backfill_request.reprocess_behavior is ReprocessBehavior.FAILED: | ||
if dr.state != DagRunState.FAILED: | ||
non_create_reason = BackfillDagRunExceptionReason.ALREADY_EXISTS | ||
if not non_create_reason: | ||
backfill_response_item.append(BackfillRunInfo(logical_date=info.logical_date)) | ||
|
||
else: | ||
backfill_response_item.append(BackfillRunInfo(logical_date=info.logical_date)) | ||
|
||
return BackfillDryRunResponse(run_info_list=backfill_response_item) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will only have logical date, no data interval?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the logical date is a datetime, so for example for DAGs with schedules other than daily, the response will still include the dates on which the backfill will be triggered. I imagine that the user likely has an understanding of the dag's schedule when making a backfill request. Does including the data interval provide additional value in this context?